This repository was archived by the owner on May 28, 2025. It is now read-only.
Make sure UIAlertViews are always rendered vertically #2652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frameworks/UIKit/UIAlertView.mm
Outdated
| delete alertPriv; | ||
|
|
||
| [super dealloc]; | ||
| } |
There was a problem hiding this comment.
This file is impossible to review; did the line endings change? #Resolved
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Doh - nice catch. Reinstall of git seems to have stomped my settings.
In reply to: 113998959 [](ancestors = 113998959,113998799)
yiyang-msft
reviewed
Apr 28, 2017
Frameworks/UIKit/UIAlertView.mm
Outdated
|
|
||
| - (void) _handleRotation { | ||
| // We need to offset the 'presentationTransform' used in WOCDispalyMode, because we always want to render alerts vertically. | ||
| // TODO: We'll remove this when we switch UIAlertView over to a Xaml ContentDialog, since rotation will be handled for us. |
Contributor
There was a problem hiding this comment.
nit: if we have WI#, we can put it here so that we don't forget to remove this. #Resolved
Contributor
Author
There was a problem hiding this comment.
Basically this whole file will be gutted at that time. I don't think this particular backlog item has been filed on github though... #Resolved
Contributor
|
|
DHowett-MSFT
suggested changes
Apr 28, 2017
DHowett-MSFT
left a comment
DHowett-MSFT
left a comment
There was a problem hiding this comment.
This file is converted to Windows line endings, but our repository is intended to be used with git config core.autocrlf true:
Confirmation:
duhowett@DHOWETT-DEV:/mnt/e/src/WinObjC$ git fetch https://github.com/jaredhms/WinObjC uialertview
git show FETCH_HEAD:remote: Counting objects: 5, done.
remote: Compressing objects: 100% (5/5), done.
remote: Total 5 (delta 0), reused 0 (delta 0), pack-reused 0
Unpacking objects: 100% (5/5), done.
./From https://github.com/jaredhms/WinObjC
* branch uialertview -> FETCH_HEAD
duhowett@DHOWETT-DEV:/mnt/e/src/WinObjC$ git show FETCH_HEAD:./Frameworks/UIKit/UIAlertView.mm | xxd | head
00000000: 2f2f 2a2a 2a2a 2a2a 2a2a 2a2a 2a2a 2a2a //**************
00000010: 2a2a 2a2a 2a2a 2a2a 2a2a 2a2a 2a2a 2a2a ****************
00000020: 2a2a 2a2a 2a2a 2a2a 2a2a 2a2a 2a2a 2a2a ****************
00000030: 2a2a 2a2a 2a2a 2a2a 2a2a 2a2a 2a2a 2a2a ****************
00000040: 2a2a 2a2a 2a2a 2a2a 2a2a 2a2a 2a2a 2a2a ****************
00000050: 0d0a 2f2f 0d0a 2f2f 2043 6f70 7972 6967 ..//..// Copyrig
At 0x00000050, the "0d0a" (and everywhere else) is a Windows line ending.
Did you flatten your machine and configure core.autocrlf?
Member
|
|
WoCDisplayMode uses a 'presentationTransform' to rotate the presentation surface for certan apps, but we don't want to use that transform to rotate UIAlertViews (else they render sideways if the app is rotated). This will be handled automatically when we move UIAlertView over Xaml (as we've already done for UIActionSheet), but for now we need to undo the 'presentationTransform' rotation for UIAlertViews. Fixes microsoft#2611.
DHowett-MSFT
approved these changes
Apr 28, 2017
| } | ||
|
|
||
| - (void) _handleRotation { | ||
| // We need to offset the 'presentationTransform' used in WOCDispalyMode, because we always want to render alerts vertically. |
rajsesh
pushed a commit
that referenced
this pull request
May 10, 2017
WoCDisplayMode uses a 'presentationTransform' to rotate the presentation surface for certan apps, but we don't want to use that transform to rotate UIAlertViews (else they render sideways if the app is rotated). This will be handled automatically when we move UIAlertView over Xaml (as we've already done for UIActionSheet), but for now we need to undo the 'presentationTransform' rotation for UIAlertViews. Fixes #2611.
rajsesh
pushed a commit
that referenced
this pull request
May 10, 2017
WoCDisplayMode uses a 'presentationTransform' to rotate the presentation surface for certan apps, but we don't want to use that transform to rotate UIAlertViews (else they render sideways if the app is rotated). This will be handled automatically when we move UIAlertView over Xaml (as we've already done for UIActionSheet), but for now we need to undo the 'presentationTransform' rotation for UIAlertViews. Fixes #2611.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WoCDisplayMode uses a 'presentationTransform' to rotate the presentation surface for certan apps, but we don't want to use that transform to rotate UIAlertViews (else they render sideways if the app is rotated). This will be handled automatically when we move UIAlertView over Xaml (as we've already done for UIActionSheet), but for now we need to undo the 'presentationTransform' rotation for UIAlertViews.
Fixes #2611.