Fix duplicate screen reader announcements in Color page copy buttons#2091
Merged
Fix duplicate screen reader announcements in Color page copy buttons#2091
Conversation
Co-authored-by: ayushjai19 <244442986+ayushjai19@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix screen reader announcing copied message twice
Fix duplicate screen reader announcements in Color page copy buttons
Dec 18, 2025
marcelwgn
approved these changes
Dec 18, 2025
Contributor
|
/azp run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen readers announce "Brush name copied to clipboard, Copied to clipboard" when copying color brush names - the message is duplicated because both
CopyButton's internal handler andColorTile's custom handler trigger accessibility announcements.Changes
CopiedMessagedependency property to allow customization of the announcement (defaults to "Copied to clipboard")CopiedMessage="Brush name copied to clipboard"on the button, remove duplicateUIHelper.AnnounceActionForAccessibilitycallExample
Applies to all color sections (Text, Signal, Fill, Background, Stroke, HighContrast).
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
0t3vsblobprodcus362.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/EB23B7D1B15B85081672081E55C17E18/missingpackages_workingdir --packages /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)1p7vsblobprodcus324.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/E25CD4A82AF7DCCAC78C9E3EDD9CC1BB/missingpackages_workingdir --packages /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)51yvsblobprodcus36.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/A5067618043C36E803E5020505C5E40F/missingpackages_workingdir --packages /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)6s7vsblobprodcus313.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/7F0AD5B89EC078FE77CFD6BDA2F52E08/missingpackages_workingdir --packages /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)96bvsblobprodcus338.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/WinUI-Gallery/WinUI-Gallery/tests/WinUIGallery.UITests/WinUIGallery.UITests.csproj --packages /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot(dns block)e7bvsblobprodcus348.vsblob.vsassets.io/usr/bin/dotnet dotnet build WinUIGallery/WinUIGallery.csproj --configuration Release(dns block)/usr/bin/dotnet dotnet restore WinUIGallery/WinUIGallery.csproj(dns block)/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/WinUI-Gallery/WinUI-Gallery/WinUIGallery.sln --packages /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot(dns block)gbsvsblobprodcus365.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/7C8EA345233C92F4CB2BB9658BB2AA46/missingpackages_workingdir --packages /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)ibzvsblobprodcus369.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/WinUI-Gallery/WinUI-Gallery/tests/WinUIGallery.UITests/WinUIGallery.UITests.csproj --packages /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot(dns block)jd4vsblobprodcus366.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/DE17E2442CB5BCCE3B8E9B4256A655B4/missingpackages_workingdir --packages /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)k4kvsblobprodcus344.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/AFED770A6C82C3D0C8515A8A32ECB221/missingpackages_workingdir --packages /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force sharp/working/emptyFakeDotnetRoot csharp/working/emptyFakeDotnetRoot(dns block)kmuvsblobprodcus389.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/0A8D2B0114395BB81780675AAD5BD541/missingpackages_workingdir --packages /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)ofvvsblobprodcus315.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/C1A6874189F3A3E4F1A43CCA7F065BAD/missingpackages_workingdir --packages /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)pkvvsblobprodcus321.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/WinUI-Gallery/WinUI-Gallery/tests/WinUIGallery.UITests/WinUIGallery.UITests.csproj --packages /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot(dns block)uy6vsblobprodcus34.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/9385D6F79C8C3B1189EF0A92FFB71E10/missingpackages_workingdir --packages /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)vb4vsblobprodcus33.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/2BA3A66AC79FC725BB64C9C1AA39E377/missingpackages_workingdir --packages /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)vwvvsblobprodcus334.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/780211A2D4C6297318C9E18BBEC72052/missingpackages_workingdir --packages /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)ytvvsblobprodcus310.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/WinUI-Gallery/WinUI-Gallery/tests/WinUIGallery.UITests/WinUIGallery.UITests.csproj --packages /home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/WinUI-Gallery/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.