Skip to content

Adjust code sample layout and minimum height#2101

Merged
niels9001 merged 2 commits intomicrosoft:mainfrom
Zakariathr22:code-sample-layout-height
Feb 9, 2026
Merged

Adjust code sample layout and minimum height#2101
niels9001 merged 2 commits intomicrosoft:mainfrom
Zakariathr22:code-sample-layout-height

Conversation

@Zakariathr22
Copy link
Contributor

Description

Added MinHeight to CodePresenter for better visibility. Reduced bottom margin of XamlPresenter in ColorPage to tighten spacing below code samples.

Motivation and Context

How Has This Been Tested?

Manually tested

Screenshots (if appropriate):

Before

image

After

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Added MinHeight to CodePresenter for better visibility. Reduced bottom margin of XamlPresenter in ColorPage to tighten spacing below code samples.
Copy link
Collaborator

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that it works! Thanks!

@niels9001 niels9001 enabled auto-merge (squash) February 8, 2026 16:44
@niels9001
Copy link
Collaborator

/azp run

1 similar comment
@niels9001
Copy link
Collaborator

/azp run

@niels9001 niels9001 merged commit 1baaf43 into microsoft:main Feb 9, 2026
2 checks passed
@Jay-o-Way

This comment was marked as outdated.

@Jay-o-Way
Copy link
Contributor

@ghost1372 (just so you know) This PR is related to the changes in #1540 where Grid Rows and the Header were removed from SampleCodePresenter; presumably because it was thought that Visual State "InlineSample" wasn't used??

@niels9001
Copy link
Collaborator

niels9001 commented Feb 9, 2026

@Zakariathr22 and @niels9001 you both missed the fact that the Wrap (still) doesn't seem to be working

Text is wrapping just fine..

image

@Jay-o-Way
Copy link
Contributor

Oh sorry, then the screenshot must have been made after the height adjustment and before the Wrap property was added 🤐

@Zakariathr22
Copy link
Contributor Author

Zakariathr22 commented Feb 9, 2026

Oh sorry, then the screenshot must have been made after the height adjustment and before the Wrap property was added 🤐

Yeah 😆, I noticed the text wrapping issue just after I opened this PR so I pushed this commit to fix it rapidly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants