Add InkCanvas and InkToolBar control pages#2168
Open
Nitin-100 wants to merge 33 commits into
Open
Conversation
…anW/WinUI-Gallery into manodasanw/aot_submodule
Author
|
Pairs with microsoft-ui-xaml-lift PR #15101676 which adds the InkCanvas and InkToolBar lifted controls these pages exercise. |
Author
|
Holding this PR pending rebase onto upstream main after the WASDK 2.0 layout migration. Will resubmit on the new .slnx layout post-May-26 CC. Demo pages validated locally May 14 against the WinUI3 InkCanvas/InkToolBar implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Gallery demo pages for the new
InkCanvasandInkToolBarlifted controls being introduced in WinAppSDK 2.0 / WinUI 3. These pages let users explore inking end-to-end inside WinUI Gallery alongside the existing controls.Pairs with the corresponding
microsoft-ui-xaml-liftPR that ships the controls themselves: PR #15101676 (user/nitinc/inking-support→main).What's added
WinUIGallery/ControlPages/InkCanvasPage.xaml(+378)WinUIGallery/ControlPages/InkCanvasPage.xaml.cs(+774)WinUIGallery/ControlPages/InkToolBarPage.xaml(+76)WinUIGallery/ControlPages/InkToolBarPage.xaml.cs(+35)WinUIGallery/DataModel/ControlInfoData.json(+19)WinUIGallery/WinUIGallery.csproj(+2)Directory.Build.props,nuget.config(+3)Total: 8 files, +1,287 lines, all additive — no existing Gallery files modified destructively.
Validation
Built and ran locally on Windows 11 (amd64chk WinUI Gallery layout) against the matching lifted-controls DLL from PR #15101676. End-to-end checks pass:
BeginDry/EndDrycycles fire)PointerPressing/Moving/ReleasingRPC_E_WRONG_THREAD) under switcher-engaged compositionNotes for reviewers