feat: add rust port of echo app#5
Merged
wmmc88 merged 1 commit intomicrosoft:mainfrom Jan 5, 2024
Merged
Conversation
wmmc88
requested changes
Oct 23, 2023
sfudally
force-pushed
the
sample_app
branch
4 times, most recently
from
50163af to
1f69225
Compare
rajeshbg
previously approved these changes
Nov 1, 2023
wmmc88
reviewed
Nov 1, 2023
Collaborator
wmmc88
left a comment
wmmc88
left a comment
There was a problem hiding this comment.
Latest changes LGTM. Only remaining tasks is the safety comments and the latest iteration failing clippy
wmmc88
approved these changes
Nov 21, 2023
Collaborator
There was a problem hiding this comment.
I noticed that clippy is still throwing some errors, but that's on me for not setting up pipelines on this sample repo yet. i will address these remaining errors when i enable pipeline enforcement on the repo.
That being said, I this pr is good to go in. Thanks again for the contribution @sfudally!
wmmc88
changed the title
hamzamust
approved these changes
Jan 4, 2024
hamzamust
left a comment
hamzamust
left a comment
There was a problem hiding this comment.
Lgtm. Thank you for porting this app!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a port of the sample app for the echo driver. It is not a 'from-scratch' Rust executable to help make it a bit easier to diff against the original C implementation sample.