Fix CppConsoleDll README output#641
Merged
Merged
Conversation
Align the documented expected output with the exported function that the console client actually calls, and remove the unused GetTestMessage function pointer typedef. ADO: 61791036 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dabhattimsft
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetOrtVersionStringcall path.GetTestMessageFunctypedef from the console client.Rationale
ADO 61791036 reports a README/code mismatch around
GetTestMessage. Instead of adding a new sample DLL export just to satisfy the README, this keeps the sample focused on the real exported function already used by the client.Validation
git diff --checkMSBuild ConsoleClient.vcxproj /p:Configuration=Release /p:Platform=x64 /p:BuildProjectReferences=falseFull project-reference build is currently blocked by an existing
WindowsAppRuntimeAutoInitializer.cppduplicate object output issue inWindowsMLWrapper.vcxproj, unrelated to this README/typedef cleanup.Fixes ADO 61791036.