Merged
Conversation
Set "Preview" metadata label to "true"
ghost
added
the
DefaultRyan
requested review from
BenJKuhn,
DrusTheAxe,
Scottj1s and
evelynwu-msft
Member
Author
|
I just now noticed #1177 from Scott. I'll just go ahead and update that here and now. |
…n.Preview VSIX identity
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Heh, beat me to requesting you do that. :) |
BenJKuhn
reviewed
Aug 4, 2021
| <PackageManifest Version="2.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011" xmlns:d="http://schemas.microsoft.com/developer/vsx-schema-design/2011"> | ||
| <Metadata> | ||
| <Identity Id="Microsoft.WindowsAppSDK" Version="|%CurrentProject%;GetVSIXVersion|" Language="en-US" Publisher="Microsoft" /> | ||
| <Identity Id="Microsoft.ProjectReunion" Version="|%CurrentProject%;GetVSIXVersion|" Language="en-US" Publisher="Microsoft" /> |
Member
There was a problem hiding this comment.
Should the identity differ between experimental and stable/preview builds, so as not to collide?
Member
Author
There was a problem hiding this comment.
It already does. See the XmlPoke stuff in the csproj. It detects if EnableExperimentalVSIXFeatures is set, and dynamically updates the Identity, DisplayName, Tags, and (new to this PR) Preview fields in the manifest.
Contributor
There was a problem hiding this comment.
The Identity is modified by the XmlPoke task on line 306 of WindowsAppSDK.Extension.csproj
kythant
pushed a commit
that referenced
this pull request
Aug 5, 2021
* Rename preview VSIX to experimental Set "Preview" metadata label to "true" * Restore original Microsoft.ProjectReunion and Microsoft.ProjectReunion.Preview VSIX identity
kythant
added a commit
that referenced
this pull request
Aug 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the experimental VSIX name to show (Experimental) instead of (Preview), to be consistent with our release channels.
Also, this sets in the metadata to "true" to enable the "Preview" label on the VSIX, as described in the linked article.
https://devblogs.microsoft.com/visualstudio/new-preview-label-for-visual-studio-extensions-2/
Image copied from article with added oval and arrows to highlight difference.
