[1.7] Fix TerminalVelocityFeatures-CallingPreviewSupport.h to be generated. #5108#5109
Merged
codendone merged 2 commits intorelease/1.7-stablefrom Feb 7, 2025
Conversation
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JesseCol
approved these changes
Feb 6, 2025
DrusTheAxe
approved these changes
Feb 6, 2025
DrusTheAxe
reviewed
Feb 6, 2025
DrusTheAxe
reviewed
Feb 6, 2025
DrusTheAxe
requested changes
Feb 6, 2025
Member
DrusTheAxe
left a comment
DrusTheAxe
left a comment
There was a problem hiding this comment.
Something's amiss - there's an existing AppNotifications .xml and .h and now the AppNotifications .xml is creating a new .h? Naming be match
And if the existing .h is obsolete it should be deleted (or updated/revised from updated/revised xml)
DrusTheAxe
approved these changes
Feb 6, 2025
Member
|
P.S. See #5111 to help prevent these pains in the future |
Contributor
|
[heart] Jesse Collins reacted to your message:
…________________________________
From: Howard Kapustein ***@***.***>
Sent: Thursday, February 6, 2025 7:09:07 PM
To: microsoft/WindowsAppSDK ***@***.***>
Cc: Jesse Collins ***@***.***>; Comment ***@***.***>
Subject: Re: [microsoft/WindowsAppSDK] [1.7] Fix TerminalVelocityFeatures-CallingPreviewSupport.h to be generated. #5108 (PR #5109)
P.S. See #5111<#5111> to help prevent these pains in the future
—
Reply to this email directly, view it on GitHub<#5109 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AL6TYI3QVIZOMWY7BRC4CFT2OOXNHAVCNFSM6AAAAABWUAWWECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBQG43DENBYHA>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
codendone
deleted the
user/codendone/generateCallingPreviewSupportVelocity
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick #5108 to 1.7.