Remove erroneous UniversalBGTask.Task.Run definition #5313
Conversation
Drive-by: improve CoCreateInstance call (avoids leaks and hardcoded GUID) Solves microsoft/cppwinrt#1485
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The CI failure seems unrelated to the PR. |
| runtimeclass Task : Windows.ApplicationModel.Background.IBackgroundTask | ||
| { | ||
| Task(); | ||
| void Run(Windows.ApplicationModel.Background.IBackgroundTaskInstance taskInstance); |
There was a problem hiding this comment.
Or do we want to nuke the [default_interface] above instead?
There was a problem hiding this comment.
We could nuke it, ITask doesn't really serve any purpose, but this specific line has to go either way.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I don't think repeating the build runs is going to solve anything here @godlytalias. What's the way forward for external contributions? |
|
It appears that pipeline runs from external contributors are missing access to internal nuget feeds. Is there a way to move this forward without a pipelines pass, or a way to fix pipelines for external contributors? |
|
Successful pipeline run: https://microsoft.visualstudio.com/ProjectReunion/_build/results?buildId=120206406&view=results |
4 participants
Drive-by: improve CoCreateInstance call (avoids leaks and hardcoded GUID)
Solves microsoft/cppwinrt#1485
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.