Merged
Conversation
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses duplicate preprocessor definition warnings in MSBuild targets by refactoring how preprocessor definitions are applied. It also introduces an ARM64EC + LTCG Internal Compiler Error (ICE) workaround.
Changes:
- Moved preprocessor definitions from Target-level ClCompile item metadata to ItemDefinitionGroup to apply globally and eliminate duplicates
- Removed the
WindowsAppSDKBootstrapAutoInitializeOptions_Nonepreprocessor definition (appears intentional as "None" likely means no options should be set) - Added ARM64EC + LTCG ICE workaround that compiles WindowsAppRuntimeAutoInitializer.cpp twice with different object file names when specific conditions are met
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| WindowsAppSDK-Nuget-Native.UndockedRegFreeWinRT.targets | Refactored preprocessor definitions to ItemDefinitionGroup; removed conditions that controlled when features are enabled |
| WindowsAppSDK-Nuget-Native.DeploymentManager.targets | Moved preprocessor definitions to ItemDefinitionGroup |
| WindowsAppSDK-Nuget-Native.Bootstrap.targets | Moved preprocessor definitions to ItemDefinitionGroup; removed Options_None definition |
| WindowsAppSDK-Nuget-Native.AutoInitializer.targets | Moved preprocessor definitions to ItemDefinitionGroup; added ARM64EC compiler workaround with duplicate compilation |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Scottj1s
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.