ApplicationData: Refactor to dual-type pattern for packaged/unpackaged#6378
Merged
Conversation
Replace runtime branching (if m_unpackagedApplicationData) with separate WinRT implementation types. Both ApplicationData and UnpackagedApplicationData now derive directly from ApplicationDataT, and the factory constructs the appropriate type. Same pattern applied to ApplicationDataContainer. This eliminates 17+ repeated if-checks, removes the shared_ptr indirection for containers, and makes each type self-contained with no branching.
DrusTheAxe
reviewed
May 26, 2026
Updated function signatures to use [[maybe_unused]] for unused parameters.
agniuks
approved these changes
May 27, 2026
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Scottj1s
added a commit
that referenced
this pull request
May 27, 2026
#6378) * ApplicationData: Refactor to dual-type pattern for packaged/unpackaged Replace runtime branching (if m_unpackagedApplicationData) with separate WinRT implementation types. Both ApplicationData and UnpackagedApplicationData now derive directly from ApplicationDataT, and the factory constructs the appropriate type. Same pattern applied to ApplicationDataContainer. This eliminates 17+ repeated if-checks, removes the shared_ptr indirection for containers, and makes each type self-contained with no branching. * Add [[maybe_unused]] to parameters in UnpackagedApplicationData Updated function signatures to use [[maybe_unused]] for unused parameters. --------- Co-authored-by: agniuks <41223743+agniuks@users.noreply.github.com>
Scottj1s
added a commit
that referenced
this pull request
May 28, 2026
…ata.GetForUnpackaged() (#6371) * ApplicationData: Unpackaged support (#6277) * ApplicationData.GetForUnpackaged() and supporting implementation * Integrated UnpackagedApplicationData into ApplicationData * Added tests. Removed debugging and dead code * 61684930: [2.0 servicing] WindowsAppSDK: Microsoft.Windows.Storage.ApplicationData.GetForUnpackaged() * Fixed RuntimeCompatibility symbol reference * ApplicationData: Refactor to dual-type pattern for packaged/unpackaged (#6378) * ApplicationData: Refactor to dual-type pattern for packaged/unpackaged Replace runtime branching (if m_unpackagedApplicationData) with separate WinRT implementation types. Both ApplicationData and UnpackagedApplicationData now derive directly from ApplicationDataT, and the factory constructs the appropriate type. Same pattern applied to ApplicationDataContainer. This eliminates 17+ repeated if-checks, removes the shared_ptr indirection for containers, and makes each type self-contained with no branching. * Add [[maybe_unused]] to parameters in UnpackagedApplicationData Updated function signatures to use [[maybe_unused]] for unused parameters. --------- Co-authored-by: agniuks <41223743+agniuks@users.noreply.github.com> * Update change ID for GetForUnpackaged method --------- Co-authored-by: agniuks <41223743+agniuks@users.noreply.github.com> Co-authored-by: Scott Jones <sjones@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace runtime branching (if m_unpackagedApplicationData) with separate WinRT implementation types. Both ApplicationData and UnpackagedApplicationData now derive directly from ApplicationDataT, and the factory constructs the appropriate type. Same pattern applied to ApplicationDataContainer.
This eliminates 17+ repeated if-checks, removes the shared_ptr indirection for containers, and makes each type self-contained with no branching.
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.