DynamicDependencies: fix PCWSTR[] access#872
Merged
DrusTheAxe merged 2 commits intomainfrom May 27, 2021
Merged
Conversation
DrusTheAxe
added
bug
ghost
added
the
Member
|
Is there a test that was failing, and now won't be? What issue # are you fixing? |
huichen123
approved these changes
May 27, 2021
jonwis
approved these changes
May 27, 2021
Comment on lines
+47
to
48
| const auto packageFullName{ packageFullNames[index] }; | ||
| packageFullNamesList.push_back(std::wstring(packageFullName)); |
Member
There was a problem hiding this comment.
Suggested change
| const auto packageFullName{ packageFullNames[index] }; | |
| packageFullNamesList.push_back(std::wstring(packageFullName)); | |
| packageFullNamesList.emplace_back(packageFullNames[index]); |
Member
Author
|
BenJKuhn
approved these changes
May 27, 2021
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BenJKuhn
pushed a commit
that referenced
this pull request
May 27, 2021
* Fixed cert enumeration (incorrect probing caused failures) * Fixed incorrect PCWSTR[] access
BenJKuhn
added a commit
that referenced
this pull request
May 27, 2021
DrusTheAxe
added a commit
that referenced
this pull request
Jun 14, 2021
* Fixed cert enumeration (incorrect probing caused failures) * Fixed incorrect PCWSTR[] access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixed cert access in DevCheck.ps1 causing false errors