Skip to content

Add UseWinUI property#897

Merged
huichen123 merged 2 commits intomainfrom
user/huichen/usewinui
Jun 2, 2021
Merged

Add UseWinUI property#897
huichen123 merged 2 commits intomainfrom
user/huichen/usewinui

Conversation

@huichen123
Copy link
Copy Markdown
Contributor

We will use this property to identify WinUI project.

@ghost ghost added the needs-triage label Jun 1, 2021
@dotMorten
Copy link
Copy Markdown
Contributor

dotMorten commented Jun 1, 2021

I'm curious what this property does, since there are no ms build changes?
Would have been cleaner that the WinUI package set this for you if it was needed (but that would require nuget dependency hierarchy to be more logically ordered, so you don't get the WinUI package transitively like it is now - see #893)

@huichen123
Copy link
Copy Markdown
Contributor Author

I'm curious what this property does, since there are no ms build changes?
Would have been cleaner that the WinUI package set this for you if it was needed (but that would require nuget dependency hierarchy to be more logically ordered, so you don't get the WinUI package transitively like it is now - see #893)

The property will be used to exclude WinUI stuff from those not interesting in WinUI. The build change is targeted for 1.0. Getting this property in first so that 0.8 can be upgraded to 1.0 (i am not saying there will be no other breaking change though).

Copy link
Copy Markdown
Contributor

@evelynwu-msft evelynwu-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@huichen123 huichen123 merged commit 54f5253 into main Jun 2, 2021
@huichen123 huichen123 deleted the user/huichen/usewinui branch June 2, 2021 00:12
huichen123 added a commit that referenced this pull request Jun 2, 2021
huichen123 added a commit that referenced this pull request Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants