Skip to content

fix unhandled error occurs when loading a file with invalid XML forma…#438

Merged
lovettchris merged 1 commit intomicrosoft:masterfrom
pontaGC:master
Sep 1, 2025
Merged

fix unhandled error occurs when loading a file with invalid XML forma…#438
lovettchris merged 1 commit intomicrosoft:masterfrom
pontaGC:master

Conversation

@pontaGC
Copy link
Copy Markdown
Contributor

@pontaGC pontaGC commented Feb 2, 2025

Hello,

I discovered that an unexpected error occurs when reading an empty file as the schema file in the schema dialog.
The cause of the occurrence was that XmlException was not taken into account when loading the schema file.
This is a minor improvement, as currently there is error checking when committing changes in the schema dialog.

I tested loading the invalid schema file below and verified that no unexpected errors occur (I verified that it goes through the exception path I added).

  1. empty file
  2. XSD file with unclosed XML tag
  3. XSD file opened in another process

@pontaGC
Copy link
Copy Markdown
Contributor Author

pontaGC commented Feb 2, 2025

@microsoft-github-policy-service agree

@lovettchris
Copy link
Copy Markdown
Member

Thanks for this fix.

@lovettchris lovettchris merged commit 1eab079 into microsoft:master Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants