fix unhandled error occurs when loading a file with invalid XML forma…#438
Merged
lovettchris merged 1 commit intomicrosoft:masterfrom Sep 1, 2025
Merged
fix unhandled error occurs when loading a file with invalid XML forma…#438lovettchris merged 1 commit intomicrosoft:masterfrom
lovettchris merged 1 commit intomicrosoft:masterfrom
Conversation
…t in the schema dialog.
Contributor
Author
|
@microsoft-github-policy-service agree |
Member
|
Thanks for this fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I discovered that an unexpected error occurs when reading an empty file as the schema file in the schema dialog.
The cause of the occurrence was that XmlException was not taken into account when loading the schema file.
This is a minor improvement, as currently there is error checking when committing changes in the schema dialog.
I tested loading the invalid schema file below and verified that no unexpected errors occur (I verified that it goes through the exception path I added).