Python: Potential fix for code scanning alert no. 48: Clear-text logging of sensitive information#3633
Draft
Python: Potential fix for code scanning alert no. 48: Clear-text logging of sensitive information#3633
Conversation
…ensitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/microsoft/agent-framework/security/code-scanning/48
In general, to fix clear-text logging of sensitive information, avoid logging the full sensitive value. Instead, either omit it entirely from logs or log only a non-sensitive snippet or a redacted/masked version. The code already has a
log_valueflag meant precisely to control this behavior; the correct fix is to ensure that this flag is respected consistently in all logging paths.Concretely, in
_try_powerfx_eval, theexceptblock currently always logs the fullvaluewhensafe_modeisTrue(since that’s the default path) and conditionally logs a snippet only whenlog_valueisFalse. To preserve current observability while protecting sensitive values, we can: (1) compute avalue_reprstring that is either the full value or a truncated snippet depending onlog_value, and (2) always usevalue_reprin the log message instead ofvaluedirectly. This way, callers likeApiKeyConnectionthat passlog_value=Falsewill never cause the full API key to be logged, regardless of_safe_mode_context. The change is local to_try_powerfx_evalinpython/packages/declarative/agent_framework_declarative/_models.py; no new imports or helpers are required.Suggested fixes powered by Copilot Autofix. Review carefully before merging.