-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add project name filter to solution #4231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -140,15 +140,21 @@ jobs: | |
| popd | ||
| rm -rf "$TEMP_DIR" | ||
|
|
||
| - name: Generate filtered solution | ||
| - name: Generate filtered solutions | ||
| shell: pwsh | ||
| run: | | ||
| .github/workflows/New-FrameworkFilteredSolution.ps1 ` | ||
| -Solution dotnet/agent-framework-dotnet.slnx ` | ||
| -TargetFramework ${{ matrix.targetFramework }} ` | ||
| -Configuration ${{ matrix.configuration }} ` | ||
| -OutputPath dotnet/filtered.slnx ` | ||
| -Verbose | ||
| $commonArgs = @{ | ||
| Solution = "dotnet/agent-framework-dotnet.slnx" | ||
| TargetFramework = "${{ matrix.targetFramework }}" | ||
| Configuration = "${{ matrix.configuration }}" | ||
| Verbose = $true | ||
| } | ||
| .github/workflows/New-FrameworkFilteredSolution.ps1 @commonArgs ` | ||
| -ProjectNameFilter "*UnitTests*" ` | ||
| -OutputPath dotnet/filtered-unit.slnx | ||
| .github/workflows/New-FrameworkFilteredSolution.ps1 @commonArgs ` | ||
| -ProjectNameFilter "*IntegrationTests*" ` | ||
| -OutputPath dotnet/filtered-integration.slnx | ||
|
Comment on lines
+155
to
+157
|
||
|
|
||
| - name: Run Unit Tests | ||
| shell: pwsh | ||
|
|
@@ -165,13 +171,12 @@ jobs: | |
| ) | ||
| } | ||
|
|
||
| dotnet test --solution ./filtered.slnx ` | ||
| dotnet test --solution ./filtered-unit.slnx ` | ||
| -f ${{ matrix.targetFramework }} ` | ||
| -c ${{ matrix.configuration }} ` | ||
| --no-build -v Normal ` | ||
| --report-xunit-trx ` | ||
| --ignore-exit-code 8 ` | ||
| --filter-query "/*UnitTests*/*/*/*" ` | ||
| @coverageArgs | ||
| env: | ||
| # Cosmos DB Emulator connection settings | ||
|
|
@@ -203,13 +208,13 @@ jobs: | |
| working-directory: dotnet | ||
| if: github.event_name != 'pull_request' && matrix.integration-tests | ||
| run: | | ||
| dotnet test --solution ./filtered.slnx ` | ||
| dotnet test --solution ./filtered-integration.slnx ` | ||
| -f ${{ matrix.targetFramework }} ` | ||
| -c ${{ matrix.configuration }} ` | ||
| --no-build -v Normal ` | ||
| --report-xunit-trx ` | ||
| --ignore-exit-code 8 ` | ||
| --filter-query "/*IntegrationTests*/*/*/*[Category!=IntegrationDisabled]" | ||
| --filter-not-trait "Category=IntegrationDisabled" | ||
| env: | ||
| # Cosmos DB Emulator connection settings | ||
| COSMOSDB_ENDPOINT: https://localhost:8081 | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment-based usage examples reference
./eng/New-FilteredSolution.ps1, but this repository doesn’t contain aneng/directory and the script’s actual path/name is.github/workflows/New-FrameworkFilteredSolution.ps1. These examples will fail if copied; update them to point at the correct script path (and the correct solution path, e.g.dotnet/agent-framework-dotnet.slnx).