Skip to content

.NET: Disable flakey Workflow Observability tests #4416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
westey-m merged 4 commits into from
Mar 3, 2026
Merged

.NET: Disable flakey Workflow Observability tests #4416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5eb6e83
Disable flakey OffThread test
westey-m Mar 3, 2026
4fd4faa
Disable additional OffThread test
westey-m Mar 3, 2026
fdb30a2
Disable a further test
westey-m Mar 3, 2026
53bdb8d
Disable all observability tests
westey-m Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions dotnet/tests/Microsoft.Agents.AI.Workflows.UnitTests/ObservabilityTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,31 +133,31 @@ private async Task TestWorkflowEndToEndActivitiesAsync(string executionEnvironme
activityEvents.Should().Contain(e => e.Name == EventNames.WorkflowCompleted, "activity should have workflow completed event");
}

[Fact]
[Fact(Skip = "Flaky test - temporarily disabled.")]
public async Task CreatesWorkflowEndToEndActivities_WithCorrectName_DefaultAsync()
{
await this.TestWorkflowEndToEndActivitiesAsync("Default");
}

[Fact(Skip = "Flaky test - temporarily disabled. Tracked in #12345")]
[Fact(Skip = "Flaky test - temporarily disabled.")]
public async Task CreatesWorkflowEndToEndActivities_WithCorrectName_OffThreadAsync()
{
await this.TestWorkflowEndToEndActivitiesAsync("OffThread");
}

[Fact]
[Fact(Skip = "Flaky test - temporarily disabled.")]
public async Task CreatesWorkflowEndToEndActivities_WithCorrectName_ConcurrentAsync()
{
await this.TestWorkflowEndToEndActivitiesAsync("Concurrent");
}

[Fact]
[Fact(Skip = "Flaky test - temporarily disabled.")]
public async Task CreatesWorkflowEndToEndActivities_WithCorrectName_LockstepAsync()
{
await this.TestWorkflowEndToEndActivitiesAsync("Lockstep");
}

[Fact]
[Fact(Skip = "Flaky test - temporarily disabled.")]
public async Task CreatesWorkflowActivities_WithCorrectNameAsync()
{
// Arrange
Expand All @@ -182,7 +182,7 @@ public async Task CreatesWorkflowActivities_WithCorrectNameAsync()
tags.Should().ContainKey(Tags.WorkflowDefinition);
}

[Fact]
[Fact(Skip = "Flaky test - temporarily disabled.")]
public async Task TelemetryDisabledByDefault_CreatesNoActivitiesAsync()
{
// Arrange
Expand All @@ -200,7 +200,7 @@ public async Task TelemetryDisabledByDefault_CreatesNoActivitiesAsync()
capturedActivities.Should().BeEmpty("No activities should be created when telemetry is disabled (default).");
}

[Fact]
[Fact(Skip = "Flaky test - temporarily disabled.")]
public async Task WithOpenTelemetry_UsesProvidedActivitySourceAsync()
{
// Arrange
Expand Down Expand Up @@ -235,7 +235,7 @@ public async Task WithOpenTelemetry_UsesProvidedActivitySourceAsync()
"All activities should come from the user-provided ActivitySource.");
}

[Fact]
[Fact(Skip = "Flaky test - temporarily disabled.")]
public async Task DisableWorkflowBuild_PreventsWorkflowBuildActivityAsync()
{
// Arrange
Expand All @@ -255,7 +255,7 @@ public async Task DisableWorkflowBuild_PreventsWorkflowBuildActivityAsync()
"WorkflowBuild activity should be disabled.");
}

[Fact]
[Fact(Skip = "Flaky test - temporarily disabled.")]
public async Task DisableWorkflowRun_PreventsWorkflowRunActivityAsync()
{
// Arrange
Expand Down Expand Up @@ -285,7 +285,7 @@ public async Task DisableWorkflowRun_PreventsWorkflowRunActivityAsync()
"Other activities should still be created.");
}

[Fact]
[Fact(Skip = "Flaky test - temporarily disabled.")]
public async Task DisableExecutorProcess_PreventsExecutorProcessActivityAsync()
{
// Arrange
Expand All @@ -312,7 +312,7 @@ public async Task DisableExecutorProcess_PreventsExecutorProcessActivityAsync()
"Other activities should still be created.");
}

[Fact]
[Fact(Skip = "Flaky test - temporarily disabled.")]
public async Task DisableEdgeGroupProcess_PreventsEdgeGroupProcessActivityAsync()
{
// Arrange
Expand All @@ -333,7 +333,7 @@ public async Task DisableEdgeGroupProcess_PreventsEdgeGroupProcessActivityAsync(
"Other activities should still be created.");
}

[Fact]
[Fact(Skip = "Flaky test - temporarily disabled.")]
public async Task DisableMessageSend_PreventsMessageSendActivityAsync()
{
// Arrange
Expand Down Expand Up @@ -382,7 +382,7 @@ private static Workflow CreateWorkflowWithDisabledMessages()
return builder.WithOpenTelemetry(configure: opts => opts.DisableMessageSend = true).Build();
}

[Fact]
[Fact(Skip = "Flaky test - temporarily disabled.")]
public async Task EnableSensitiveData_LogsExecutorInputAndOutputAsync()
{
// Arrange
Expand Down Expand Up @@ -413,7 +413,7 @@ public async Task EnableSensitiveData_LogsExecutorInputAndOutputAsync()
tags[Tags.ExecutorOutput].Should().Contain("HELLO", "Output should contain the transformed value.");
}

[Fact]
[Fact(Skip = "Flaky test - temporarily disabled.")]
public async Task EnableSensitiveData_Disabled_DoesNotLogInputOutputAsync()
{
// Arrange
Expand Down Expand Up @@ -442,7 +442,7 @@ public async Task EnableSensitiveData_Disabled_DoesNotLogInputOutputAsync()
tags.Should().NotContainKey(Tags.ExecutorOutput, "Output should NOT be logged when EnableSensitiveData is false.");
}

[Fact]
[Fact(Skip = "Flaky test - temporarily disabled.")]
public async Task EnableSensitiveData_LogsMessageSendContentAsync()
{
// Arrange
Expand Down Expand Up @@ -474,7 +474,7 @@ public async Task EnableSensitiveData_LogsMessageSendContentAsync()
tags.Should().ContainKey(Tags.MessageSourceId, "Source ID should be logged.");
}

[Fact]
[Fact(Skip = "Flaky test - temporarily disabled.")]
public async Task EnableSensitiveData_Disabled_DoesNotLogMessageContentAsync()
{
// Arrange
Expand Down
12 changes: 6 additions & 6 deletions dotnet/tests/Microsoft.Agents.AI.Workflows.UnitTests/WorkflowRunActivityStopTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ private static Workflow CreateWorkflow()
/// Bug: The Activity created by LockstepRunEventStream.TakeEventStreamAsync is never
/// disposed because yield break in async iterators does not trigger using disposal.
/// </summary>
[Fact]
[Fact(Skip = "Flaky test - temporarily disabled.")]
public async Task WorkflowRunActivity_IsStopped_LockstepAsync()
{
// Arrange
Expand Down Expand Up @@ -111,7 +111,7 @@ public async Task WorkflowRunActivity_IsStopped_LockstepAsync()
/// Verifies that the workflow_invoke Activity is stopped when using the OffThread (Default)
/// execution environment (StreamingRunEventStream).
/// </summary>
[Fact]
[Fact(Skip = "Flaky test - temporarily disabled.")]
public async Task WorkflowRunActivity_IsStopped_OffThreadAsync()
{
// Arrange
Expand Down Expand Up @@ -156,7 +156,7 @@ public async Task WorkflowRunActivity_IsStopped_OffThreadAsync()
/// (StreamingRun.WatchStreamAsync) with the OffThread execution environment.
/// This matches the exact usage pattern described in the issue.
/// </summary>
[Fact]
[Fact(Skip = "Flaky test - temporarily disabled.")]
public async Task WorkflowRunActivity_IsStopped_Streaming_OffThreadAsync()
{
// Arrange
Expand Down Expand Up @@ -203,7 +203,7 @@ public async Task WorkflowRunActivity_IsStopped_Streaming_OffThreadAsync()
/// streaming invocation, even when using the same workflow in a multi-turn pattern,
/// and that each session gets its own session activity.
/// </summary>
[Fact]
[Fact(Skip = "Flaky test - temporarily disabled.")]
public async Task WorkflowRunActivity_IsStopped_Streaming_OffThread_MultiTurnAsync()
{
// Arrange
Expand Down Expand Up @@ -264,7 +264,7 @@ public async Task WorkflowRunActivity_IsStopped_Streaming_OffThread_MultiTurnAsy
/// Verifies that all started activities (not just workflow_invoke) are properly stopped.
/// This ensures no spans are "leaked" without being exported.
/// </summary>
[Fact]
[Fact(Skip = "Flaky test - temporarily disabled.")]
public async Task AllActivities_AreStopped_AfterWorkflowCompletionAsync()
{
// Arrange
Expand Down Expand Up @@ -305,7 +305,7 @@ public async Task AllActivities_AreStopped_AfterWorkflowCompletionAsync()
/// be parented under the workflow session span. The run activity should
/// still nest correctly under the session.
/// </summary>
[Fact]
[Fact(Skip = "Flaky test - temporarily disabled.")]
public async Task Lockstep_SessionActivity_DoesNotLeak_IntoCaller_ActivityCurrentAsync()
{
// Arrange
Expand Down
Loading