Merged
Conversation
rogerbarreto
approved these changes
Mar 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a .NET analyzer failure (CA1873) by avoiding potentially expensive log-argument evaluation when warning logging is disabled in ChatClientAgent.
Changes:
- Guard the chat history provider conflict warning log with
ILogger.IsEnabled(LogLevel.Warning). - Precompute
GetLoggingAgentName()only when the warning will actually be emitted.
giles17
approved these changes
Mar 4, 2026
alliscode
approved these changes
Mar 4, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes CA1873 warning:
Contribution Checklist