.NET: Removing old code-gen docs from dotnet root#4997
Merged
alliscode merged 2 commits intomicrosoft:mainfrom Mar 31, 2026
Merged
.NET: Removing old code-gen docs from dotnet root#4997alliscode merged 2 commits intomicrosoft:mainfrom
alliscode merged 2 commits intomicrosoft:mainfrom
Conversation
peibekwe
approved these changes
Mar 31, 2026
westey-m
approved these changes
Mar 31, 2026
lokitoth
approved these changes
Mar 31, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes outdated design/implementation markdown documents from the dotnet/ repo root to avoid confusion around the .NET workflow executor source generator feature.
Changes:
- Deleted
dotnet/wf-source-gen-changes.md - Deleted
dotnet/wf-source-gen-bp.md - Deleted
dotnet/wf-code-gen-impact.md
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dotnet/wf-source-gen-changes.md | Removed legacy implementation summary doc for the workflow executor route source generator. |
| dotnet/wf-source-gen-bp.md | Removed best-practices review doc (Roslyn cookbook comparison) for the source generator. |
| dotnet/wf-code-gen-impact.md | Removed rationale/impact doc describing the reflection-to-source-gen migration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes three design and implementation documents related to the .NET workflow executor source generator feature. The deleted files provided implementation details that are not needed and are more likely to cause confusion where they are.
Contribution Checklist