Skip to content

.NET: Update versions for release#5449

Merged
westey-m merged 1 commit intomicrosoft:mainfrom
westey-m:version-update-2026-04-23
Apr 23, 2026
Merged

.NET: Update versions for release#5449
westey-m merged 1 commit intomicrosoft:mainfrom
westey-m:version-update-2026-04-23

Conversation

@westey-m
Copy link
Copy Markdown
Contributor

Motivation and Context

Description

Contribution Checklist

  • The code builds clean without any errors or warnings
  • The PR follows the Contribution Guidelines
  • All unit tests pass, and I have added new tests where possible
  • Is this a breaking change? If yes, add "[BREAKING]" prefix to the title of the PR.

Copilot AI review requested due to automatic review settings April 23, 2026 16:22
@moonbox3 moonbox3 added the .NET label Apr 23, 2026
@github-actions github-actions Bot changed the title Update versions for release .NET: Update versions for release Apr 23, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Bumps the .NET NuGet package versioning metadata in preparation for the next release, using the centralized nuget-package.props properties that drive package version and tagging.

Changes:

  • Update VersionPrefix from 1.2.0 to 1.3.0
  • Update DateSuffix from 260421 to 260423
  • Update GitTag from 1.2.0 to 1.3.0

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated Code Review

Reviewers: 4 | Confidence: 95%

✓ Correctness

Straightforward version bump from 1.2.0 to 1.3.0 with DateSuffix updated to today's date (260423). All three changes (VersionPrefix, DateSuffix, GitTag) are internally consistent: VersionPrefix and GitTag both move to 1.3.0, and the PackageVersion conditions all derive from $(VersionPrefix) so they will correctly pick up the new version. No correctness issues found.

✓ Security Reliability

This is a straightforward version bump from 1.2.0 to 1.3.0 in the central NuGet package properties file, with the DateSuffix updated from 260421 to 260423 (matching today's date of April 23, 2026). The VersionPrefix and GitTag are updated consistently. No security or reliability concerns.

✓ Test Coverage

This is a straightforward version bump from 1.2.0 to 1.3.0 in the NuGet package properties file, along with an updated date suffix (260421 → 260423) and matching GitTag update. This is a build/packaging configuration change with no behavioral code modifications, so there is no new or changed behavior that would require test coverage. No issues found.

✗ Design Approach

The version bump is mostly self-consistent, but it misses the release-contract update that keeps package validation meaningful for GA packages. Advancing the shared package version to 1.3.0 while leaving the validation baseline at 1.0.0 means released packages will continue comparing against a much older baseline instead of the latest published stable version, which can hide compatibility regressions introduced after 1.0.0.

Suggestions

  • Treat VersionPrefix/GitTag and PackageValidationBaselineVersion as one unit of release bookkeeping so GA validation always compares against the immediately previous stable release.

Automated review by westey-m's agents

Comment thread dotnet/nuget/nuget-package.props
@westey-m westey-m enabled auto-merge April 23, 2026 16:40
@westey-m westey-m added this pull request to the merge queue Apr 23, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 23, 2026
@westey-m westey-m added this pull request to the merge queue Apr 23, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 23, 2026
@westey-m westey-m added this pull request to the merge queue Apr 23, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 23, 2026
@westey-m westey-m added this pull request to the merge queue Apr 23, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 23, 2026
@westey-m westey-m added this pull request to the merge queue Apr 23, 2026
Merged via the queue into microsoft:main with commit 4d3e4f8 Apr 23, 2026
40 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants