Python: consume Anthropic beta flags#5772
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an Anthropic client integration issue where per-run additional_beta_flags were being forwarded as a raw request kwarg (causing Anthropic SDK TypeErrors) instead of being consumed into the betas set used for the request.
Changes:
- Remove
additional_beta_flagsfrom the finalrun_optionsafter it has been merged intobetas. - Add a regression test ensuring
additional_beta_flagsis consumed intobetasand not forwarded.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| python/packages/anthropic/agent_framework_anthropic/_chat_client.py | Pops additional_beta_flags from run_options after preparing betas to prevent forwarding unsupported kwargs. |
| python/packages/anthropic/tests/test_anthropic_client.py | Adds a regression test to verify additional_beta_flags is consumed into betas and removed from run_options. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
additional_beta_flagsinto the Anthropic beta set without forwarding it as a raw request kwarg_prepare_options(...)Fixes #5764.
To verify
uv run pytest tests/test_anthropic_client.py -quv run ruff check agent_framework_anthropic tests/test_anthropic_client.pyuv run ruff format --check agent_framework_anthropic tests/test_anthropic_client.pyuv run pyrightuv run mypy --config-file pyproject.toml agent_framework_anthropicpython -m py_compile agent_framework_anthropic\_chat_client.py tests\test_anthropic_client.py