.NET: accept stringified inline skill arguments#6033
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for passing skill arguments as a JSON object encoded inside a JSON string, and validates the behavior with a new unit test.
Changes:
- Parse
JsonValueKind.Stringarguments as JSON (when they contain JSON text) before converting toAIFunctionArguments. - Add a unit test covering JSON-string-encoded object arguments.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| dotnet/src/Microsoft.Agents.AI/Skills/Programmatic/AgentInlineSkillScript.cs | Adds logic to parse string arguments as JSON before enforcing object-kind arguments. |
| dotnet/tests/Microsoft.Agents.AI.UnitTests/AgentSkills/AgentInlineSkillScriptTests.cs | Adds a test ensuring JSON object text inside a JSON string is accepted and mapped to parameters. |
Comment on lines
+105
to
+107
| catch (JsonException) | ||
| { | ||
| arguments = arguments.Value; |
| } | ||
| catch (JsonException) | ||
| { | ||
| arguments = arguments.Value; |
Comment on lines
+52
to
+53
| using var argsDoc = JsonDocument.Parse("\"{\\\"a\\\":3,\\\"b\\\":7}\""); | ||
| var args = argsDoc.RootElement; |
| // Arrange | ||
| var script = new AgentInlineSkillScript("add", (int a, int b) => a + b); | ||
| var skill = new AgentInlineSkill("calc-skill", "Calc.", "Instructions."); | ||
| using var argsDoc = JsonDocument.Parse("\"{\\\"a\\\":3,\\\"b\\\":7}\""); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6020.
To verify
Note: dotnet test still hits the existing Microsoft.Testing.Platform/VSTest runner error on .NET 10 SDK, so I used the project runner directly.