.NET: Bumping version for dotnet release.#6816
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the central .NET NuGet package version metadata to prepare for the next release cycle.
Changes:
- Bumped the shared NuGet
VersionPrefixfrom1.11.1to1.12.0. - Updated
DateSuffixto260629and alignedGitTagto1.12.0.
Show a summary per file
| File | Description |
|---|---|
| dotnet/nuget/nuget-package.props | Updates shared NuGet versioning properties (VersionPrefix/DateSuffix/GitTag) for the .NET release bump. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
There was a problem hiding this comment.
Automated Code Review
Reviewers: 5 | Confidence: 95%
✓ Correctness
This is a straightforward version bump PR that updates VersionPrefix from 1.11.1 to 1.12.0, GitTag from 1.11.1 to 1.12.0, and DateSuffix from 260625 to 260629. All three values are consistent with each other and the PR's stated intent. No correctness issues found.
✓ Security Reliability
This is a straightforward version bump PR changing the .NET package version from 1.11.1 to 1.12.0, updating the DateSuffix from 260625 to 260629, and aligning the GitTag accordingly. No security or reliability concerns — the changes are purely declarative version metadata in an MSBuild props file with no logic, no secrets, and no trust-boundary implications.
✓ Test Coverage
This PR is a straightforward version bump from 1.11.1 to 1.12.0 in the NuGet package properties file, with a corresponding DateSuffix update. There are no behavioral code changes—only version metadata updates in a build configuration file. No new tests are needed since there is no new or changed runtime behavior to cover.
✓ Failure Modes
This is a straightforward version bump PR (1.11.1 → 1.12.0) with an updated date suffix (260625 → 260629) and matching GitTag update. All three version-related values are internally consistent. There are no failure modes, silent failures, or operational issues introduced by this change.
✗ Design Approach
The version bump itself is straightforward, but it leaves the shared package-validation baseline untouched at
1.0.0. Because released packages import this props file and enable package validation, that makes the release process keep validating GA packages against the initial release instead of the current published baseline, which is inconsistent with the repo’s documented release contract.
Flagged Issues
- The release bump in
dotnet/nuget-package.propsis incomplete becausePackageValidationBaselineVersionremains1.0.0, even though the file says it "should be the latest version available on NuGet" (dotnet/nuget-package.props:16-19) and CONTRIBUTING says to update it after each release (CONTRIBUTING.md:100-105). Released packages such asdotnet/src/Microsoft.Agents.AI/Microsoft.Agents.AI.csproj:4,18import this file withIsReleased=true, so GA compatibility validation will keep comparing against an obsolete baseline.
Automated review by alliscode's agents
| <PropertyGroup> | ||
| <!-- Central version prefix - applies to all nuget packages. --> | ||
| <VersionPrefix>1.11.1</VersionPrefix> | ||
| <VersionPrefix>1.12.0</VersionPrefix> |
There was a problem hiding this comment.
This release bump updates VersionPrefix, but the shared package-validation baseline in the same file is still 1.0.0 (dotnet/nuget-package.props:16-19). That contradicts both the local invariant that the baseline "should be the latest version available on NuGet" and the documented release step in CONTRIBUTING.md:100-105. Since released packages import this file and set IsReleased=true (for example dotnet/src/Microsoft.Agents.AI/Microsoft.Agents.AI.csproj:4,18), leaving the stale baseline means GA validation will continue comparing against the initial release instead of the current public package line.
|
Flagged issue The release bump in Source: automated DevFlow PR review |
Bump version for .NET release
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.