fix room_selector example which always run the first task #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ultmaster
approved these changes
Nov 4, 2025
Contributor
|
/ci |
|
🚀 CI Watcher for correlation id-3486595127-mhkq7yy9 triggered by comment 3486595127
✅ All runs completed. |
totoluo
pushed a commit
to totoluo/agent-lightning
that referenced
this pull request
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
room_selectorexample, the runner incorrectly executes the first task (tasks[0]) on every step instead of advancing to the next one.As a result, the example produces inconsistent outputs: the
expected_choiceand final result are mismatched, but the model is still assigned a high reward.