Dashboard - build into Python package #291

ultmaster · 2025-11-11T06:31:15Z

and a lot of bug fixes...

Copilot

Pull Request Overview

This PR integrates the dashboard as a built asset into the Python package, enabling the Agent-Lightning server to serve the web UI directly. Key changes include updating the build pipeline, fixing bugs in both frontend and backend code, and improving test coverage with Storybook integration.

Key Changes

Dashboard assets are now built and packaged with the Python distribution
API routes restructured with a dedicated router and SPA fallback handling
Enhanced frontend functionality with query parameter support, improved search, and better responsive layouts
Added comprehensive Storybook tests and vitest browser testing setup

Reviewed Changes

Copilot reviewed 28 out of 31 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
agentlightning/store/client_server.py	Added dashboard static file serving, API router refactor, and SPA fallback routes
pyproject.toml	Configured package to include dashboard HTML/JS/CSS/SVG assets
dashboard/vite.config.mjs	Updated build output directory and added vitest browser testing support
dashboard/src/pages/Traces.page.tsx	Implemented query parameter hydration, rollout search, and improved state management
dashboard/src/utils/table.ts	Fixed responsive column calculations with dynamic EM-to-pixel conversion
dashboard/src/components/AppDrawer.component.tsx	Added navigation link to traces page with query params
dashboard/src/features/rollouts/api.ts	Fixed span normalization to preserve raw attribute structure
.github/workflows/*.yml	Added Node.js setup and dashboard build steps to CI/CD pipelines

Files not reviewed (1)

dashboard/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-11T06:34:38Z

dashboard/vite.config.mjs

+const dirname = typeof __dirname !== 'undefined' ? __dirname : path.dirname(fileURLToPath(import.meta.url));
+
+// More info at: https://storybook.js.org/docs/next/writing-tests/integrations/vitest-addon
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = path.dirname(__filename);


Duplicate variable declarations for __dirname and __filename. Line 13 defines dirname with a fallback, but lines 16-17 redefine __filename and __dirname unconditionally. Consider removing lines 16-17 and renaming dirname to __dirname on line 13, or if the fallback is needed for specific environments, remove the redundant declarations.

Copilot · 2025-11-11T06:34:39Z

dashboard/src/features/rollouts/api.ts

+    attributes: (value as any).attributes ?? {},
+    context: (value as any).context ?? {},
+    parent: (value as any).parent ?? null,
+    resource: (value as any).resource ?? {},


Bypassing the camelCase conversion by casting value as any to preserve the original structure. While this may be intentional to maintain the raw format of these fields, it creates inconsistency with the rest of the normalized object which uses camelized. Consider documenting why these specific fields need to preserve their original casing, or ensure the backend consistently uses the expected case.

Suggested change

resource: (value as any).resource ?? {},

resource: camelCaseKeys((value as any).resource ?? {}),

Copilot · 2025-11-11T06:34:39Z

agentlightning/store/client_server.py

+            return FileResponse(index_file)
+
+        @self.app.get("/{full_path:path}", include_in_schema=False)
+        def spa_fallback(full_path: str):  # pyright: ignore[reportUnusedFunction]


The SPA fallback route /{full_path:path} could potentially intercept API requests if they don't exactly match the registered routes. FastAPI route ordering matters - this catch-all route is registered after the API router on line 799, but if an API route has a typo or slight variation, it would incorrectly serve the index.html. Consider adding a guard condition to check if full_path starts with 'v1' and return a 404 instead of serving the SPA.

Suggested change

def spa_fallback(full_path: str): # pyright: ignore[reportUnusedFunction]

def spa_fallback(full_path: str): # pyright: ignore[reportUnusedFunction]

# If the path looks like an API route, return 404

if full_path.startswith("v1"):

raise HTTPException(status_code=404, detail="Not Found")

Copilot · 2025-11-11T06:34:39Z

dashboard/src/pages/Settings.page.tsx

  { label: 'Off', value: '0' },
-  { label: 'Every 5 seconds', value: '5000' },
-  { label: 'Every 15 seconds', value: '15000' },
-  { label: 'Every 60 seconds', value: '60000' },
-  { label: 'Every 5 minutes', value: '300000' },
+  // TODO: Support real auto-refresh
+  { label: 'Every 5 seconds', value: '5000', disabled: true },
+  { label: 'Every 15 seconds', value: '15000', disabled: true },
+  { label: 'Every 60 seconds', value: '60000', disabled: true },
+  { label: 'Every 5 minutes', value: '300000', disabled: true },


[nitpick] Auto-refresh options are disabled with a TODO comment in the code, but users won't see any explanation in the UI. Consider adding a helper text or tooltip to inform users that auto-refresh functionality is coming soon, or remove these disabled options entirely until the feature is implemented.

Copilot · 2025-11-11T06:34:40Z

dashboard/src/layouts/AppLayout.tsx


    check();

+    // FIXME: autorefresh only refresh server status, not the data


[nitpick] FIXME comment indicates auto-refresh only updates server status, not the actual data. This is related to the disabled auto-refresh options in Settings.page.tsx. Consider filing a tracking issue for this limitation and referencing it in both comments for better traceability.

Suggested change

// FIXME: autorefresh only refresh server status, not the data

// FIXME: autorefresh only refreshes server status, not the actual data.

// See tracking issue: https://github.com/your-org/your-repo/issues/1234

// This is related to the disabled auto-refresh options in Settings.page.tsx.

Copilot · 2025-11-11T06:34:40Z

dashboard/vite.config.mjs

 import { defineConfig } from 'vite';
 import tsconfigPaths from 'vite-tsconfig-paths';

+const dirname = typeof __dirname !== 'undefined' ? __dirname : path.dirname(fileURLToPath(import.meta.url));


Variable '__dirname' is used before its declaration.

ultmaster · 2025-11-11T06:38:22Z

/ci

github-actions · 2025-11-11T06:38:41Z

🚀 CI Watcher for correlation id-3515208606-mhu7a10c triggered by comment 3515208606
🏃‍♀️ Tracking 6 workflow run(s):

🟢 PR #291 - Label ci-all - id-3515208606-mhu7a10c — completed/success
🟢 PR #291 - Label ci-all - id-3515208606-mhu7a10c — completed/success
🔴 PR #291 - Label ci-all - id-3515208606-mhu7a10c — completed/failure
🟢 PR #291 - Label ci-all - id-3515208606-mhu7a10c — completed/success
🟢 PR #291 - Label ci-all - id-3515208606-mhu7a10c — completed/success
🟢 PR #291 - Label ci-all - id-3515208606-mhu7a10c — completed/success

✅ All runs completed.

ultmaster added 17 commits November 11, 2025 08:43

add route

4d382f2

Install dashboard

6d64a5e

update client server

fa27306

.

149110a

fix table overflow issue

884614c

drawer overflow fixes and trace url fixes

4dbc413

fix favicon

16799a4

fix column width

d25ec96

.

5b60032

.

63ac23d

.

af332fd

UI adjustment

f0dc93d

.

762a17f

fix api camel case

1b2807f

setup vitest storybook

122181c

fix stories chromatic issues

9da9b47

fix dashboard build

95481d8

Copilot AI review requested due to automatic review settings November 11, 2025 06:31

ultmaster added the ci-all label Nov 11, 2025

Copilot started reviewing on behalf of ultmaster November 11, 2025 06:31 View session

.

0952a35

Copilot finished reviewing on behalf of ultmaster November 11, 2025 06:33

Copilot AI reviewed Nov 11, 2025

View reviewed changes

ultmaster added 2 commits November 11, 2025 14:45

.

cbdf474

.

5051fbc

ultmaster merged commit 2ab977e into main Nov 11, 2025
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dashboard - build into Python package #291

Dashboard - build into Python package #291

Uh oh!

ultmaster commented Nov 11, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 11, 2025

Uh oh!

Copilot AI Nov 11, 2025

Uh oh!

Copilot AI Nov 11, 2025

Uh oh!

Copilot AI Nov 11, 2025

Uh oh!

Copilot AI Nov 11, 2025

Uh oh!

Copilot AI Nov 11, 2025

Uh oh!

ultmaster commented Nov 11, 2025

Uh oh!

github-actions bot commented Nov 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	resource: (value as any).resource ?? {},
	resource: camelCaseKeys((value as any).resource ?? {}),

-        def spa_fallback(full_path: str):  # pyright: ignore[reportUnusedFunction]
+        def spa_fallback(full_path: str):  # pyright: ignore[reportUnusedFunction]
+            # If the path looks like an API route, return 404
+            if full_path.startswith("v1"):
+                raise HTTPException(status_code=404, detail="Not Found")


		check();

		// FIXME: autorefresh only refresh server status, not the data

-    // FIXME: autorefresh only refresh server status, not the data
+    // FIXME: autorefresh only refreshes server status, not the actual data.
+    // See tracking issue: https://github.com/your-org/your-repo/issues/1234
+    // This is related to the disabled auto-refresh options in Settings.page.tsx.

Dashboard - build into Python package #291

Dashboard - build into Python package #291

Uh oh!

Conversation

ultmaster commented Nov 11, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

ultmaster commented Nov 11, 2025

Uh oh!

github-actions bot commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Nov 11, 2025 •

edited

Loading