Improve cross-platform compatibility for Windows #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add explicit UTF-8 encoding to all file operations to ensure consistent behavior across Windows and Unix systems - Fix chmod() call in key_manager.py to skip on Windows where NTFS already restricts file permissions to the user - Prevents encoding errors on Windows where default encoding may differ from UTF-8 - Ensures configuration files, transcripts, and API key files work reliably on all platforms
Contributor
Author
|
@microsoft-github-policy-service agree company=Microsoft |
Collaborator
|
Closing this PR to resolve merge conflicts with #10 (atomic write refactor) which has been merged. The valuable UTF-8 encoding and Windows chmod fixes from this PR will be cherry-picked into a clean PR with credit to @brycecutt-msft. Thank you for the contribution! |
bkrabach
added a commit
that referenced
this pull request
Nov 27, 2025
- Add explicit encoding="utf-8" to all file operations to ensure consistent behavior across Windows and Unix systems - Fix chmod() call in key_manager.py to skip on Windows where NTFS already restricts file permissions to the user - Prevents encoding errors on Windows where default encoding may differ from UTF-8 - Ensures configuration files, transcripts, and API key files work reliably on all platforms Based on PR #9 by @brycecutt-msft - thank you for the contribution! 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Bryce Cutt <brycecutt@microsoft.com> Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
3 tasks
bkrabach
added a commit
that referenced
this pull request
Nov 27, 2025
- Add explicit encoding="utf-8" to all file operations to ensure consistent behavior across Windows and Unix systems - Fix chmod() call in key_manager.py to skip on Windows where NTFS already restricts file permissions to the user - Prevents encoding errors on Windows where default encoding may differ from UTF-8 - Ensures configuration files, transcripts, and API key files work reliably on all platforms Based on PR #9 by @brycecutt-msft - thank you for the contribution! 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-authored-by: Bryce Cutt <brycecutt@microsoft.com> Co-authored-by: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
robotdad
added a commit
to robotdad/amplifier-app-cli
that referenced
this pull request
Jan 7, 2026
Completes the fix for bundle removal by calling the unregister() method added in amplifier-foundation PR microsoft#9. Previously, 'amplifier bundle remove' only removed bundles from the user registry but left them in the foundation registry's in-memory state. Changes: - Call BundleRegistry.unregister() to remove from foundation registry - Call registry.save() to persist the removal - Provide detailed feedback about which registries were affected - Handle errors gracefully with warning messages Companion PR to: microsoft/amplifier-foundation#9 🤖 Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
4 tasks
bkrabach
pushed a commit
that referenced
this pull request
Jan 7, 2026
Completes the fix for bundle removal by calling the unregister() method added in amplifier-foundation PR #9. Previously, 'amplifier bundle remove' only removed bundles from the user registry but left them in the foundation registry's in-memory state. Changes: - Call BundleRegistry.unregister() to remove from foundation registry - Call registry.save() to persist the removal - Provide detailed feedback about which registries were affected - Handle errors gracefully with warning messages Companion PR to: microsoft/amplifier-foundation#9 🤖 Generated with Amplifier Co-authored-by: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses Windows-specific encoding and permission handling issues to improve cross-platform compatibility.
Changes
Impact