Skip to content

Conversation

@bengry
Copy link
Contributor

@bengry bengry commented Dec 19, 2018

This PR aims to add a declarative syntax to all fab-*-buttons components (fab-default-button, fab-action-button etc.) for declaring menu items:

<fab-default-button text="Contact me">
  <contextual-menu-item key="email" text="Email" (click)="sendEmail()"></contextual-menu-item>
  <contextual-menu-item key="phone" text="Phone" (click)="call()"></contextual-menu-item>
</fab-default-button>

Also addresses <contextual-menu-item> directive items not having a comparable declarative syntax for their render and renderIcon inputs counterparts in IContextualMenuItem. Note that the overriding of an icon render doesn't work due to a bug in office-ui-fabric-react.


Related issue: #3

…stom icon render

the custom icon render doesn't work due to an office-ui-fabric-react bug
@bengry bengry force-pushed the fabric/base-button-menu branch from 25c39eb to 04d9397 Compare December 19, 2018 14:54
@bengry bengry force-pushed the fabric/base-button-menu branch from 04d9397 to d168704 Compare December 19, 2018 15:00
@bengry bengry merged commit 0bf7d9a into master Dec 19, 2018
@bengry bengry deleted the fabric/base-button-menu branch December 19, 2018 15:02
@bengry bengry restored the fabric/base-button-menu branch January 2, 2019 16:45
@bengry bengry deleted the fabric/base-button-menu branch January 2, 2019 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants