Take benefits from tree-shaking support in Fabric #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@bengry could you please take a review? |
bengry
approved these changes
Jan 26, 2019
Contributor
bengry
left a comment
bengry
left a comment
There was a problem hiding this comment.
@shadowglen Looks fine. I left one comment regarding the umd ids. Would appreciate further explanation there.
libs/fabric/src/lib/components/pickers/base-picker/base-picker.module.ts
Outdated
Show resolved
Hide resolved
libs/fabric/src/lib/components/pickers/tag-picker/tag-picker.module.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks @bengry, could you please bump the version and publish to npmjs? |
Contributor
|
@shadowglen just did. #84 (do note to update both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify the Fabric UMD module id reference to
{ "office-ui-fabric-react": "Fabric" }, which is exported in official UMD bundle.