-
Notifications
You must be signed in to change notification settings - Fork 148
[BUG] apm marketplace build fails for GitHub Enterprise Server repositories #1008
Copy link
Copy link
Open
Labels
area/enterpriseAir-gapped/GHE configurability, registry proxy, rulesets, adoption playbook.Air-gapped/GHE configurability, registry proxy, rulesets, adoption playbook.area/marketplacemarketplace.json schema, federation, authoring suite, source parity.marketplace.json schema, federation, authoring suite, source parity.priority/highShips in current or next milestoneShips in current or next milestonestatus/acceptedDirection approved, safe to start work.Direction approved, safe to start work.status/triagedInitial agentic triage complete; pending maintainer ratification (silence = approval).Initial agentic triage complete; pending maintainer ratification (silence = approval).theme/portabilityOne manifest, every target. Multi-target deploy, marketplace, packaging, install.One manifest, every target. Multi-target deploy, marketplace, packaging, install.type/featureNew capability, new flag, new primitive.New capability, new flag, new primitive.
Milestone
Metadata
Metadata
Assignees
Labels
area/enterpriseAir-gapped/GHE configurability, registry proxy, rulesets, adoption playbook.Air-gapped/GHE configurability, registry proxy, rulesets, adoption playbook.area/marketplacemarketplace.json schema, federation, authoring suite, source parity.marketplace.json schema, federation, authoring suite, source parity.priority/highShips in current or next milestoneShips in current or next milestonestatus/acceptedDirection approved, safe to start work.Direction approved, safe to start work.status/triagedInitial agentic triage complete; pending maintainer ratification (silence = approval).Initial agentic triage complete; pending maintainer ratification (silence = approval).theme/portabilityOne manifest, every target. Multi-target deploy, marketplace, packaging, install.One manifest, every target. Multi-target deploy, marketplace, packaging, install.type/featureNew capability, new flag, new primitive.New capability, new flag, new primitive.
Type
Projects
Status
In Progress
Describe the bug
Running
apm marketplace buildagainst a marketplace whose packages are hosted on a GitHub Enterprise Server (GHES) instance always fails with a Git authentication error, even whenGITHUB_HOSTand a valid GHE token are set in the environment.The error message reveals that APM is contacting
github.cominstead of the configured GHE host, so authentication always fails regardless of the credentials provided.To Reproduce
Steps to reproduce the behavior:
marketplace.ymlwith packages sourced from a GHES instance (e.g.corp.ghe.com)GITHUB_HOST=corp.ghe.comin the environmentGITHUB_TOKENto a valid personal access token for that GHE instanceapm marketplace build --dry-run --verboseNote the remote URL in the error — it points to
github.cominstead of the GHE host, confirmingGITHUB_HOSTis not being respected.Expected behavior
Setting
GITHUB_HOST=corp.ghe.comshould causeapm marketplace buildto resolve package refs against that host, consistent with howapm installalready supports thehost/owner/reposyntax for GHE repos.Environment:
Logs
Additional context
This affects the
marketplace-authoringexperimental feature. Theapm installcommand supports GHE viahost/owner/reponotation, so there is precedent for GHE support in APM. Themarketplace buildcommand appears to not yet have equivalent support.