[BUG] Copilot hook events are never renamed to camelCase

[sproott]

Describe the bug

The docs state hook files may be authored in the Claude (PreToolUse,
PostToolUse) or Copilot (preToolUse, postToolUse) shape and that "events
are renamed per target during merge." For the copilot target this rename
never happens: apm install warns about a casing mismatch and deploys the
event unrenamed.

Root cause is in
hook_integrator.py:

• _HOOK_EVENT_MAP has entries for claude, gemini, and kiro, but no
  copilot entry — while _HOOK_EVENT_EXPECTED_CASING["copilot"] = "camelCase", so _emit_hook_event_diagnostics flags PostToolUse as an
  unmappable "casing mismatch."
• The Copilot deploy path also calls the diagnostic with a hard-coded empty map
  (_emit_hook_event_diagnostics(..., "copilot", {})) and writes the events
  through unchanged, so it never applies a mapping even if one existed.

A fix needs both: a copilot mapping (PreToolUse→preToolUse,
PostToolUse→postToolUse) and for the Copilot path to apply it during merge.

To Reproduce

1. Use a package with a hook authored in the Claude shape
   ({ "hooks": { "PostToolUse": [...] } }) and copilot in targets.
2. Run apm install.
3. See the casing warning; .github/hooks/<pkg>-<file>.json keeps PostToolUse.

Hook events for target 'copilot' may not be recognized: PostToolUse. Target
expects camelCase (e.g. preToolUse). Rename events to match the camelCase
convention, then reinstall.
WARNING apm_cli.integration.hook_integrator target copilot: hook event casing mismatch (no mapping): PostToolUse

(In the same run the gemini target is renamed correctly to AfterTool,
confirming the per-target rename machinery works for targets that have a mapping.)

Expected behavior

The Copilot target renames PostToolUse → postToolUse automatically and emits
no warning.

Environment

• OS: Linux (Arch Linux)
• Python Version: 3.12
• APM Version: 0.23.1

Logs

See the warning block above.

Additional context

Minimal reproduction: https://github.com/sproott/apm-bugs (make copilot-rename).

[github-actions]

Triage Panel Verdict

Issue: [BUG] Copilot hook events are never renamed to camelCase
Reporter: @sproott

Panel Assessment

Python Architect
Precise root-cause diagnosis in the report. Two defects in hook_integrator.py:

1. _HOOK_EVENT_MAP has entries for claude, gemini, and kiro but no copilot entry -- despite _HOOK_EVENT_EXPECTED_CASING["copilot"] = "camelCase" signalling that camelCase renaming is expected for this target.
2. The Copilot deploy path passes a hard-coded empty map {} to _emit_hook_event_diagnostics instead of _HOOK_EVENT_MAP.get("copilot", {}), so even if a mapping were added, the Copilot path would not apply it.

Fix is bounded and fully specified: (a) add "copilot": {"PreToolUse": "preToolUse", "PostToolUse": "postToolUse"} to _HOOK_EVENT_MAP; (b) update the Copilot deploy path to pass _HOOK_EVENT_MAP.get("copilot", {}) instead of {}. This is a good first issue -- the scope is narrow, the fix is clear, and a minimal reproduction repo is provided.

DevX UX Expert
The warning ("Rename events to match the camelCase convention, then reinstall") puts the remediation burden on the user for a bug that APM should handle transparently. The Copilot-target hook rename machinery is documented as automatic -- shipping a warning instead of silently fixing is a confusing violation of the stated contract.

APM CEO Arbiter
Clear regression with complete diagnosis and a minimal reproduction. High priority -- affects every user installing a hook-bearing package targeting copilot. The fix is tiny and safe. Recommended as a good first issue for a contributor, with the reporter having done the hard diagnostic work already.

---

Decision

Dimension	Value
Type	bug
Theme	portability (per-target hook rename consistency)
Area	cli
Priority	high
Status	accepted (diagnosis complete, fix well-scoped)
Milestone	none (no active milestone; target next patch)

Labels to apply: theme/portability, area/cli, priority/high, good first issue, status/triaged

Suggested next action: In src/apm_cli/integration/hook_integrator.py: (1) add "copilot": {"PreToolUse": "preToolUse", "PostToolUse": "postToolUse"} to _HOOK_EVENT_MAP; (2) change the Copilot deploy path from _emit_hook_event_diagnostics(..., "copilot", {}) to use _HOOK_EVENT_MAP.get("copilot", {}). Add a test using the minimal reproduction from https://github.com/sproott/apm-bugs.

---

Triage status: agentic proposal pending human ratification.
Silence is approval. Maintainers can:

• Override any label or milestone above by editing it directly --
  human edits are authoritative and will not be reverted on
  subsequent runs.
• Re-trigger triage by applying the status/needs-triage label, or
  by removing status/triaged to enroll the issue in the next
  daily sweep.

Posted by the Triage Panel workflow. See .apm/skills/apm-triage-panel for the panel skill.

Generated by Triage Panel · 81.8 AIC · ⌖ 6.99 AIC · ⊞ 9.2K · ◷