test(release-validation): pass --target copilot to apm init on Windows#1180
Merged
danielmeppiel merged 1 commit intomainfrom May 7, 2026
Merged
Conversation
The .ps1 mirror of test-release-validation.sh was missed in #1171. Bash script already passes '--target copilot' to 'apm init --yes' so the resulting apm.yml has an explicit target. Without the flag on Windows, the fresh project has no target and no .github/ signal, so the next 'apm install microsoft/apm-sample-package' exits 2 under post-#1154 strict harness detection. Why only Windows: the mirror gap. macOS/Linux release validation has been passing this flag since #1171. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns the Windows release-validation script with the Unix shell mirror so Hero Scenario 2 initializes a project with an explicit Copilot harness target, preventing subsequent apm install from failing closed on Windows due to missing harness detection.
Changes:
- Update
apm initinvocation in the Windows release-validation script to include--target copilot. - Update the corresponding
Write-Host“Running:” line to match the actual command being executed.
Show a summary per file
| File | Description |
|---|---|
| scripts/windows/test-release-validation.ps1 | Passes --target copilot to apm init in Hero Scenario 2 to ensure apm.yml declares a target and downstream steps behave consistently on Windows. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Hero scenario 2 of release validation fails only on Windows (run 25484129617) because the
.ps1mirror oftest-release-validation.shwas missed when #1171 added--target copilottoapm init --yes.Why only Windows
apm initinvocationscripts/test-release-validation.sh:224apm init my-project --yes --target copilotscripts/windows/test-release-validation.ps1:263(before this PR)apm init my-project --yes(missing)Without
--target copilotthe resultingapm.ymlhas no target, the freshmy-project/has no.github/signal, and the next stepapm install microsoft/apm-sample-packageexits 2 under post-#1154 strict harness detection.Fix
One-line addition: pass
--target copilottoapm initin the Windows release-validation script, matching the.shmirror.Follow-up
After merge, retag
v0.12.3to the new merge SHA so the release pipeline reruns.Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com