ci(panels): pin target=copilot for pr-review-panel and triage-panel#1192
Merged
Conversation
Both panels run on the gh-aw default Copilot CLI engine, so they only need the 'copilot' layout from the apm package. Pinning target=copilot (via the new shared/apm.md input from #1184) ships a slim per-harness bundle instead of installing all seven harnesses on every panel run. This also side-steps the cowork-in-all crash that hit the apm self-check (run 25511043293) before #1191 landed; the panels now explicitly request a single supported harness, so an experimental target leaking into 'all' could not regress these workflows again. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Pins the gh-aw panel workflows to a single APM harness (target: copilot) so the generated bundle only includes the Copilot/GitHub harness layout needed by the panel engine, avoiding unnecessary multi-target packing.
Changes:
- Set
target: copiloton theshared/apm.mdimport in both panel workflow sources. - Regenerated both gh-aw lock workflows so the packed APM bundle uses
target: copilotinstead ofall.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/triage-panel.md | Adds target: copilot to the shared/apm.md import inputs. |
| .github/workflows/triage-panel.lock.yml | Regenerated lock workflow; pack step now uses target: copilot. |
| .github/workflows/pr-review-panel.md | Adds target: copilot to the shared/apm.md import inputs. |
| .github/workflows/pr-review-panel.lock.yml | Regenerated lock workflow; pack step now uses target: copilot. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Pin
target: copiloton both panel workflows now thatshared/apm.mdexposes the newtarget:input (#1184).Why
Both panels run on the gh-aw default Copilot CLI engine. Without an explicit
target:they fell back toall, which:.github/copilot-instructions.mdis consumed by the engine.allwas leaking the experimentalcopilot-coworktarget into project-scope installs.What
.github/workflows/pr-review-panel.md: addtarget: copilotto theshared/apm.mdimport..github/workflows/triage-panel.md: same.gh aw compileregenerated both lock files; verified the substitution baked through (target: copilotin the lock,frontmatter_hashupdated,agent_id: copilotunchanged).Defence in depth
Even if
--target allregressed again upstream, these workflows now request a single supported harness explicitly, so an experimental target leaking intoallcould not re-break the panels via this code path.