fix(tests): repair 2 integration tests that surfaced post-#1257#1261
Merged
danielmeppiel merged 1 commit intomainfrom May 11, 2026
Merged
fix(tests): repair 2 integration tests that surfaced post-#1257#1261danielmeppiel merged 1 commit intomainfrom
danielmeppiel merged 1 commit intomainfrom
Conversation
Two integration tests were green in the merge queue (because the suite was not yet wired in) and surfaced as failures only after #1257 enabled the runner. 1. test_deployed_files_are_under_github_or_claude The lockfile correctly records '.agents/skills/<name>' for skill primitives (AGENTS.md is the cross-tool common skills format used by Codex / Cursor / OpenCode). The assertion was stale: it forbade '.agents/' even though deployment there is by design when a plugin-style package contains skills. Renamed the test to ..._under_known_target_roots and widened the allowlist to ('.github/', '.claude/', '.agents/'). 2. test_pack_unpack_e2e::test_full_round_trip 'apm unpack' is deprecated (the CLI itself prints '"apm unpack" is deprecated and will be removed in v0.14. Use "apm install <bundle-path>" instead'). Its bundle verification compares lockfile '.github/...' paths against on-disk plugin-bundle 'agents/' / 'commands/' / 'instructions/' paths and always fails -- the round-trip is structurally broken on the supported plugin bundle format. Switched the test to use the supported 'apm install <archive>' migration path and seeded a copilot signal in the consumer dir for target detection. Both failures verified locally before and after the fix. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR repairs two integration tests that started failing once the integration runner was enabled, updating expectations to match current install/pack behavior and deployed file roots.
Changes:
- Updates the pack/unpack round-trip E2E test to use
apm install <archive>instead of deprecatedapm unpack, and seeds Copilot target detection in the consumer project. - Broadens the deployed-files root assertion to allow
.agents/in addition to.github/and.claude/, and renames the test accordingly.
Show a summary per file
| File | Description |
|---|---|
| tests/integration/test_pack_unpack_e2e.py | Switches the round-trip flow from unpack to install <archive> and adjusts setup/error reporting. |
| tests/integration/test_deployed_files_e2e.py | Renames the deployed-files root test and expands the allowed root prefixes to include .agents/. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 2
Comment on lines
1
to
+3
| """End-to-end integration tests for ``apm pack`` and ``apm unpack``. | ||
|
|
||
| Round-trip tests: install → pack → unpack → verify files match. | ||
| Round-trip tests: install -> pack -> install bundle -> verify files match. |
Comment on lines
97
to
99
| # 4. Verify .github/ files are present | ||
| assert (consumer / ".github").exists(), ".github/ missing after unpack" | ||
| assert (consumer / ".github").exists(), ".github/ missing after bundle install" | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two integration tests were green in the merge queue (because the suite was not yet wired in) and surfaced as failures only after #1257 enabled the runner -- see run #25640445147.
test_deployed_files_e2e::test_deployed_files_are_under_github_or_claude.agents/skills/<name>for skill primitives (AGENTS.md is the cross-tool common skills format used by Codex / Cursor / OpenCode), but the assertion forbade.agents/...._under_known_target_rootsand widened the allowlist to('.github/', '.claude/', '.agents/').test_pack_unpack_e2e::test_full_round_tripapm unpackis deprecated (the CLI prints the migration toapm install <bundle-path>) and its bundle verification compares lockfile.github/...paths against on-disk plugin-bundleagents//commands//instructions/paths -- always fails on the supported plugin format.apm install <archive>, the documented replacement, and seeded a copilot signal in the consumer dir.Validation
Both reproduced before the fix and verified green after.
ruff check+ruff format --checkare silent.