Skip to content

docs(changelog): add #1383 SSH user fix entry#1386

Merged
danielmeppiel merged 1 commit into
mainfrom
danielmeppiel/changelog-1383
May 19, 2026
Merged

docs(changelog): add #1383 SSH user fix entry#1386
danielmeppiel merged 1 commit into
mainfrom
danielmeppiel/changelog-1383

Conversation

@danielmeppiel
Copy link
Copy Markdown
Collaborator

Adds the missing CHANGELOG entry for the SSH user fix merged in #1385 (closes #1383). Follow-up to that PR — the changelog row was overlooked.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 19, 2026 09:28
@danielmeppiel danielmeppiel merged commit 2f4cda5 into main May 19, 2026
17 checks passed
@danielmeppiel danielmeppiel deleted the danielmeppiel/changelog-1383 branch May 19, 2026 09:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds the missing changelog entry for the SSH user handling fix in apm install, documenting the behavior change and linking it to the relevant PR/issue.

Changes:

  • Add an Unreleased “Fixed” entry describing SSH user support for dependency URLs
  • Document validation behavior (strict allowlist) and reference #1385 / #1383
Show a summary per file
File Description
CHANGELOG.md Adds an Unreleased Fixed bullet documenting the SSH user fix and references the related PR/issue

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment thread CHANGELOG.md

### Fixed

- `apm install` honors the SSH user portion of dependency URLs (`ssh://user@host/...` and scp shorthand `user@host:org/repo`) instead of hardcoding `git@`; unblocks EMU accounts and other non-`git` SSH identities. User values are validated against a strict allowlist before composing the clone URL. (#1385, closes #1383)
sergio-sisternes-epam pushed a commit that referenced this pull request May 19, 2026
Co-authored-by: Daniel Meppiel <copilot-rework@github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Hardcoded username when using SSH

2 participants