[Test Improver] test: expand unit tests for list command (42% -> 100%)#444
Merged
danielmeppiel merged 4 commits intomainfrom Apr 2, 2026
Merged
Conversation
Add 12 new tests covering list_cmd.py paths previously untested: - No scripts found: warning shown with rich panel + fallback (ImportError/NameError) - Scripts found: rich table rendered with default 'start' annotation - Scripts found: fallback text when no console or rich raises - Multiple scripts all shown in fallback - Exception handling: sys.exit(1) with error message Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Expands unit test coverage for the user-facing apm list command to exercise previously untested output branches (no scripts, Rich vs fallback rendering, and error handling), improving confidence in CLI behavior.
Changes:
- Add comprehensive unit tests for empty-script behavior, including Rich panel attempt and fallback paths.
- Add tests for script listing with/without a default (
start) script across Rich and non-Rich output paths. - Add tests for exception handling to ensure failures exit with code 1 and emit an error message.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Test Improver - automated AI assistant
Goal and Rationale
list_cmd.pyis user-facing (shows available scripts to developers) but was only 42% covered. The untested paths included the "no scripts found" case, the Rich table rendering branch, and exception handling. These are all exercised regularly by users.Approach
Extended the existing
tests/unit/test_list_command.py(which had 1 test) with 12 additional tests covering:ImportError/NameErrorstartannotated as defaultstartscript: no "default script" annotation_list_available_scripts:sys.exit(1)and error message shownCoverage Impact
src/apm_cli/commands/list_cmd.pyTest Status
All 3041 unit tests pass:
Reproducibility