Data-driven integration dispatch: replace if-chain with target × primitive loop

[Copilot]

Description

The ~200-line if-chain in _integrate_package_primitives() used boolean flags (integrate_vscode, integrate_claude, integrate_opencode) to gate per-target method calls. Missing guards caused --target opencode to write to .github/ (#470). The integrators themselves had 20+ near-identical per-target methods (70–95% boilerplate), and path data was triple-encoded across KNOWN_TARGETS, the dispatch chain, and method bodies.

This PR makes integrators consume TargetProfile directly, collapsing per-target methods into parameterized ones. KNOWN_TARGETS becomes the single source of truth.

Integrators

Each file integrator gains integrate_*_for_target(target: TargetProfile, ...) and sync_for_target(target, ...). Old per-target methods become thin wrappers for backward compat.

• CommandIntegrator: 2 integrate + 2 sync → 1 parameterized each
• AgentIntegrator: 4 integrate + 4 sync + 3 filename → 1 each. Multi-target auto-copy removed from integrate_package_agents(); dispatch loop handles each target independently.
• InstructionIntegrator: 2 integrate + 2 sync → 1 each. format_id selects content transform (cursor_rules → _convert_to_cursor_rules, else identity).
• HookIntegrator: Thin integrate_hooks_for_target() dispatches by target.name (genuine algorithmic diversity preserved).
• PromptIntegrator: Thin wrappers added for uniform dispatch.

Dispatch (install.py)

# Before: boolean flags + 200-line if-chain
_integrate_package_primitives(..., integrate_vscode=True, integrate_claude=False, ...)

# After: target list + 60-line loop
_integrate_package_primitives(..., targets=_targets, ...)
# Loop: for target in targets → for primitive in target.primitives → dispatch

Uninstall (engine.py)

Phase 1 sync and Phase 2 re-integration both use target-driven loops over KNOWN_TARGETS / active_targets() instead of per-integrator calls with should_integrate_claude().

Partition (base_integrator.py)

partition_managed_files() generates buckets dynamically from KNOWN_TARGETS with backward-compat aliases (agents_copilot → agents_github, instructions_cursor → rules_cursor, etc.). Adding a target or primitive auto-creates the bucket.

Type of change

• Bug fix
• New feature
• Documentation
• Maintenance / refactor

Testing

• Tested locally
• All existing tests pass
• Added tests for new functionality (if applicable)

9 new tests added in test_data_driven_dispatch.py:

• Target-gating regression (5): opencode-only skips .github/, cursor-only skips .claude/, etc.
• Exhaustiveness (2): every (target, primitive) has a dispatch path; dynamic partition matches old hardcoded bucket keys
• Synthetic target (2): hand-built TargetProfile with custom root_dir works with real integrators — proves adding a target needs no code changes

[danielmeppiel]

Closes #482 and #488

[Copilot]

Pull request overview

Refactors integration/uninstall dispatch to a data-driven TargetProfile x primitive loop, replacing a large boolean-gated if-chain and reducing per-target boilerplate across integrators. This aligns integration behavior with KNOWN_TARGETS as the single source of truth and addresses prior target-gating regressions (e.g., opencode writing into .github/).

Changes:

• Replace boolean flag gating in install.py with a target-driven dispatch loop calling integrate_*_for_target() methods.
• Add target-driven APIs (integrate_*_for_target, sync_for_target) to integrators while keeping legacy wrappers for backward compatibility.
• Update uninstall sync/re-integration to iterate targets/primitives; add unit tests covering gating, dispatch exhaustiveness, and synthetic targets.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
tests/unit/test_uninstall_transitive_cleanup.py	Updates mocks to match new active_targets()-based uninstall reintegration flow.
tests/unit/integration/test_data_driven_dispatch.py	Adds regression/exhaustiveness tests for target x primitive dispatch and dynamic managed-file partitioning.
tests/unit/integration/test_command_integrator.py	Updates gating regression tests to use targets=[KNOWN_TARGETS[...]] and target-driven methods.
src/apm_cli/integration/prompt_integrator.py	Adds target-driven prompt integrate/sync entry points and keeps legacy API.
src/apm_cli/integration/instruction_integrator.py	Reworks instruction integration into integrate_instructions_for_target() with format_id-based transforms; adds sync_for_target() and legacy wrappers.
src/apm_cli/integration/hook_integrator.py	Adds a thin integrate_hooks_for_target() dispatcher preserving per-target hook logic.
src/apm_cli/integration/command_integrator.py	Adds integrate_commands_for_target() / sync_for_target() and rewires legacy methods to delegate.
src/apm_cli/integration/base_integrator.py	Makes partition_managed_files() generate buckets dynamically from KNOWN_TARGETS with backward-compat aliases.
src/apm_cli/integration/agent_integrator.py	Adds target-driven agent integrate/sync and consolidates filename logic via PrimitiveMapping.
src/apm_cli/commands/uninstall/engine.py	Updates uninstall cleanup + reintegration to target-driven loops using KNOWN_TARGETS / active_targets().
src/apm_cli/commands/install.py	Implements target x primitive dispatch loop in _integrate_package_primitives() and switches call sites to pass targets.

Comments suppressed due to low confidence (1)

src/apm_cli/commands/install.py:940

• CLI log messages use Unicode box-drawing characters (via \u2514\u2500) when reporting primitive integration results. This violates the repository ASCII-only output requirement and can cause encoding failures on Windows terminals. Use ASCII-only markers / bracket STATUS_SYMBOLS instead.

                _log_integration(
                    f"  \u2514\u2500 {_int_result.files_integrated} {_label} integrated -> {_deploy_dir}"
                )