Skip to content

test(marketplace): isolate test_auto_detect_through_proxy from real network #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielmeppiel merged 2 commits into from
Apr 19, 2026
+4 −1
Merged

test(marketplace): isolate test_auto_detect_through_proxy from real network #759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69236e2
test(marketplace): isolate test_auto_detect_through_proxy from real n…
danielmeppiel Apr 19, 2026
71ef40c
address review: append PR ref to changelog; drop unused classify_host…
danielmeppiel Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed

- Fix `apm marketplace add` silently failing for private repos by using credentials when probing `marketplace.json` (#701)
- Stop `test_auto_detect_through_proxy` from making real `api.github.com` calls by passing a mock `auth_resolver`, fixing flaky macOS CI rate-limit failures (#759)
- Pin codex setup to `rust-v0.118.0` for security and reproducibility; update config to `wire_api = "responses"` (#663)
- Propagate headers and environment variables through OpenCode MCP adapter with defensive copies to prevent mutation (#622)
- Fix `apm install` hanging indefinitely when corporate firewalls silently drop SSH packets by setting `GIT_SSH_COMMAND` with `ConnectTimeout=30` (#652)
Expand Down
4 changes: 3 additions & 1 deletion tests/unit/marketplace/test_marketplace_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,9 +295,11 @@ def mock_entry(*args, **kwargs):
return None # first candidate not found
return json.dumps(self._MARKETPLACE_JSON).encode()

mock_resolver = MagicMock()
mock_resolver.try_with_fallback.return_value = None
with patch("apm_cli.deps.registry_proxy.RegistryConfig.from_env", return_value=cfg), \
patch("apm_cli.deps.artifactory_entry.fetch_entry_from_archive", side_effect=mock_entry):
path = client_mod._auto_detect_path(source)
path = client_mod._auto_detect_path(source, auth_resolver=mock_resolver)

assert path == ".github/plugin/marketplace.json"

Expand Down
Loading