Add proxy variables support to appcenter-file-upload-client-node#1044
Merged
Add proxy variables support to appcenter-file-upload-client-node#1044
Conversation
added 2 commits
September 2, 2020 14:57
jp-andre
reviewed
Sep 2, 2020
Contributor
jp-andre
left a comment
There was a problem hiding this comment.
Looks go to me, but there's no test verifying that an agent is set when the env var is set.
Contributor
Author
Added a simple test. |
jp-andre
approved these changes
Sep 4, 2020
anywherepilot
pushed a commit
that referenced
this pull request
Sep 24, 2020
Updates **appcenter-file-upload-client-node** dependency and applies the new 'fetchWithOptions' method from #1044.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds proxy environment variables support to appcenter-file-upload-client-node using proxy-agent package. It should fix the problem with uploading releases using a proxy.
This PR also bumps the package version. After the PR is reviewed and tested we should publish an update to npmjs and update the dependency of the appcenter-cli and use the new
fetchWithOptionsmethod instead of 'fetch'. There's a draft PR for it.How to test:
cd appcenter-file-upload-client-node && npm packappcenter-clifetchcalls withfetchWithOptionsfrom "appcenter-file-upload-client-node". See this PR.appcenter distribute release -f appRelease.apk -g publicGroupNameTested:
Related links:
Original issue: #982
The next PR: #1045
AB#81897