[Distribution] Do not call abortReleaseUpload API when uploading file failed#1192
Merged
gordan-radojcic merged 5 commits intomicrosoft:masterfrom Jan 13, 2021
Merged
Conversation
Member
Author
|
FYI @atkhalsa |
atkhalsa
approved these changes
Dec 15, 2020
|
@dhei could you please share the PR which actually fixes the backend behavior
I think server-side should go first in such case and only if it has no issues we can complete this PR. |
andrii-z4i
approved these changes
Dec 17, 2020
MatkovIvan
approved these changes
Jan 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: We are deprecating
PATCH /v0.1/apps/{owner_name}/{app_name}/release_uploads/{upload_id}API (openapi.appcenter.ms swagger link). When calling App Center CLI with incorrect build number or incorrect build version (see command below), the CLI will call the deprecated PATCH API withabortedon file upload failure. Note this bug only reproduces when both build version and build number parameters are provided but at least one of them is invalid.appcenter distribute release --file <localFilePath> --app <appName> --group <groupName> --build-version <build-version> --build-number <build-number>We investigated the distribute backend and discovered the
abortedrelease upload status is never used in any meaningful way. We should stop usingabortedstatus.Solution: On the client-side, CLI will no longer call any aborted API on upload failure. The server side will be fixed in a different PR.