Fix getAndroidHermesEnabled#1935
Merged
DmitriyKirakosyan merged 3 commits intomicrosoft:masterfrom May 3, 2022
Merged
Conversation
Contributor
|
Hello @incleaf and thank you for your contribution! Probably it will be better to use regex? |
Contributor
Author
|
@AnatolyPristensky Agreed and applied! |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Contributor
Author
|
@AnatolyPristensky Done! |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@incleaf I've tested your change and it works as expected. Thank you for your contribution! |
DmitriyKirakosyan
approved these changes
May 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

There can be many cases where the line does not exactly match the
enableHermes: true.I don't think these changes would be the ultimate solution though 😓
Case 1
Case 2