Add "distribute release --timeout <seconds>" option for loading release id.#1948
Merged
AnatolyPristensky merged 5 commits intomicrosoft:masterfrom May 18, 2022
Conversation
Contributor
|
Hi @KojiNakamaru , Thank you for your contribution! |
Contributor
|
Hi @KojiNakamaru , I left a few comments to your changes. |
Contributor
Author
|
@DmitriyKirakosyan Thank you, I reflected your comments (194d69a). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Hello @KojiNakamaru, I see that CI Pipeline is failed with the following error message: Could you please have a look at it? |
Contributor
Author
|
@AnatolyPristensky Thank you, I specified radix 10 again (40c6666, cf. #1948 (comment) ). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
AnatolyPristensky
approved these changes
May 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add "distribute release --timeout " option for loading release id.
The uploading with
distribute releasecommand internally performs multiple steps found in https://docs.microsoft.com/en-us/appcenter/distribution/uploading . Most steps are performed without any issue, but for large ipa/apk files the step 6may take several hours regardless of the success or failure (further details can be found in the discussion with App Center Support: Distribute Issue #KVM78S6P).
This pull request allows to specify a timeout for loadReleaseIdUntilSuccess (429fa00). With this option, a user can stop appcenter-cli in reasonable time and restart it if necessary. The pull request also contains other minor refinements (0ab83dd, 0846e65).