Skip to content

Add ability to download bundle (.aab file) #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AnatolyPristensky merged 3 commits into from
Jun 1, 2022
Merged

Add ability to download bundle (.aab file) #1960

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7005bf3
Add ability to download bundle (.aab file)
DenisBalan May 31, 2022
3fbfa2c
Update download.ts
DenisBalan May 31, 2022
edb1474
Fix for prettier
DenisBalan May 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/commands/build/download.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,10 @@ const debug = require("debug")("appcenter-cli:commands:build:download");

@help("Download the binary, logs or symbols for a completed build")
export default class DownloadBuildStatusCommand extends AppCommand {
private static readonly applicationPackagesExtensions: string[] = [".apk", ".aar", ".ipa", ".xcarchive"];
private static readonly applicationPackagesExtensions: string[] = [".apk", ".aar", ".ipa", ".xcarchive", ".aab"];

private static readonly buildType = "build";
private static readonly bundleType = "bundle";
private static readonly logsType = "logs";
private static readonly symbolsType = "symbols";

Expand All @@ -45,7 +46,7 @@ export default class DownloadBuildStatusCommand extends AppCommand {
public buildId: string;

@help(
`Type of download. '${DownloadBuildStatusCommand.buildType}', '${DownloadBuildStatusCommand.logsType}', and '${DownloadBuildStatusCommand.symbolsType}' are allowed values`
`Type of download. '${DownloadBuildStatusCommand.buildType}', '${DownloadBuildStatusCommand.bundleType}', '${DownloadBuildStatusCommand.logsType}', and '${DownloadBuildStatusCommand.symbolsType}' are allowed values`
)
@shortName("t")
@longName("type")
Expand Down Expand Up @@ -103,7 +104,7 @@ export default class DownloadBuildStatusCommand extends AppCommand {
this.unpackAndWriteDirectory(zip, extension, buildInfo.sourceBranch, payloadZipEntry.name)
);
} else {
// IPA or APK
// IPA or AAB or APK
const payload = await out.progress("Extracting application package...", payloadZipEntry.async("nodebuffer"));
outputPath = await out.progress("Writing application package...", this.writeFile(payload, extension, buildInfo.sourceBranch));
}
Expand Down Expand Up @@ -149,12 +150,13 @@ export default class DownloadBuildStatusCommand extends AppCommand {
const lowerCaseType = type.toLowerCase();
if (
lowerCaseType !== DownloadBuildStatusCommand.buildType &&
lowerCaseType !== DownloadBuildStatusCommand.bundleType &&
lowerCaseType !== DownloadBuildStatusCommand.logsType &&
lowerCaseType !== DownloadBuildStatusCommand.symbolsType
) {
throw failure(
ErrorCodes.InvalidParameter,
`download type should be '${DownloadBuildStatusCommand.buildType}', '${DownloadBuildStatusCommand.logsType}' or '${DownloadBuildStatusCommand.symbolsType}'`
`download type should be '${DownloadBuildStatusCommand.bundleType}', ${DownloadBuildStatusCommand.buildType}', '${DownloadBuildStatusCommand.logsType}' or '${DownloadBuildStatusCommand.symbolsType}'`
);
}

Expand Down Expand Up @@ -241,7 +243,7 @@ export default class DownloadBuildStatusCommand extends AppCommand {
}

private getPayload(zip: JsZip): JsZip.JSZipObject {
// looking for apk, ipa or xcarchive
// looking for aab, apk, ipa or xcarchive
return _.find(_.values(zip.files) as JsZip.JSZipObject[], (file) =>
_.includes(DownloadBuildStatusCommand.applicationPackagesExtensions, Path.extname(file.name).toLowerCase())
);
Expand Down