Skip to content

Fix autogenerating XamarinUITest project#2179

Merged
DmitriyKirakosyan merged 4 commits intomasterfrom
fix-autogenerating-xamarinuitest-project
Jan 25, 2023
Merged

Fix autogenerating XamarinUITest project#2179
DmitriyKirakosyan merged 4 commits intomasterfrom
fix-autogenerating-xamarinuitest-project

Conversation

@AnatolyPristensky
Copy link
Copy Markdown
Contributor

@AnatolyPristensky AnatolyPristensky commented Dec 22, 2022

This PR fixing autogenerating XamarinUITest Project, added support of .NET6, changed test for this.

@AnatolyPristensky AnatolyPristensky requested a review from a team as a code owner December 22, 2022 12:53
thewulf7
thewulf7 previously approved these changes Jan 13, 2023
});

it("should not touch NuGet version on failure", async () => {
const latestVersion = "3.13.3";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where this number is coming from?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is version set in template. See https://github.com/microsoft/appcenter-cli/pull/2179/files#diff-43a9902987546c39cfb52668af857cb9dcda87d4b0e4a3aef24f9b102c8ed6d0R29

The test makes sure the version won't be changed after executing command with a failure.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think we need to test X.UITest version instead of version of NUnit.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread test/commands/test/generate/uitest-test.ts
@DmitriyKirakosyan DmitriyKirakosyan merged commit 1b8a527 into master Jan 25, 2023
@DmitriyKirakosyan DmitriyKirakosyan deleted the fix-autogenerating-xamarinuitest-project branch January 25, 2023 07:26
@ccYHM86
Copy link
Copy Markdown

ccYHM86 commented Jan 27, 2023

Any timeline on when this fix will be available in AppCenter? We had to disable our Launch Test on Android due to this and im curious on when it can be enabled again.

@DmitriyKirakosyan
Copy link
Copy Markdown
Contributor

@ccYHM86 , we will update you once it is updated on agents. Expected within 1-3 days.

@ccYHM86
Copy link
Copy Markdown

ccYHM86 commented Feb 3, 2023

@DmitriyKirakosyan do you have any updates on the rollout of this fix to agents? I just tried again and the build still fails during the launch test setup.

Thanks

DmitriyKirakosyan added a commit that referenced this pull request Mar 15, 2023
AnatolyPristensky added a commit that referenced this pull request Mar 16, 2023
* Revert "[test-cloud] Add NUnit3TestAdapter and Microsoft.NET.Test.Sdk to generated projects (#2214)"

This reverts commit 0e69619.

* Revert "Fix autogenerating XamarinUITest project (#2179)"

This reverts commit 1b8a527.

* Use hardcoded version of Xamarin.UITest for generated project

* Comment unused method

* Fix lint

* Fix unused import

* Remove unused tests

---------

Co-authored-by: AnatolyPristensky <v-anatpr@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants