Skip to content

Fix merge-junit-xml and merge-nunit-xml issue #2235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AnatolyPristensky merged 3 commits into from
Mar 14, 2023
Merged

Fix merge-junit-xml and merge-nunit-xml issue #2235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b7fef7
Fix merge-nunit-xml issue
ankasani Mar 9, 2023
1bea0e5
Fix merged-file-name issue
ankasani Mar 9, 2023
e0a97aa
Fixed error Delete ···· prettier/prettier
ankasani Mar 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/commands/test/run/appium.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { generateAbsolutePath } from "../../../util/misc/fs-helper";
import { CommandArgs, help, longName, hasArg, required } from "../../../util/commandline";
import { AppiumPreparer } from "../lib/appium-preparer";
import { Messages } from "../lib/help-messages";
import { XMLSerializer } from "@xmldom/xmldom";
import { JUnitXmlUtil } from "../lib/junit-xml-util";
import { RunTestsDownloadResultCommand } from "../lib/run-tests-download-result-command";

Expand Down Expand Up @@ -58,6 +59,7 @@ export default class RunAppiumTestsCommand extends RunTestsDownloadResultCommand
throw new Error(`Couldn't merge xml test results to ${this.mergeJUnitXml}`);
}

return pfs.writeFile(path.join(reportPath, this.mergeJUnitXml), xml);
const strXml: string = new XMLSerializer().serializeToString(xml);
return pfs.writeFile(path.join(reportPath, this.mergeJUnitXml), strXml);
}
}
4 changes: 3 additions & 1 deletion src/commands/test/run/manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { CommandArgs, help, longName, required, hasArg } from "../../../util/com
import { Messages } from "../lib/help-messages";
import * as path from "path";
import { writeFile, walk } from "../../../util/misc/promisfied-fs";
import { XMLSerializer } from "@xmldom/xmldom";
import { XmlUtil } from "../lib/xml-util";
import { XmlUtilBuilder } from "../lib/xml-util-builder";
import { generateAbsolutePath } from "../../../util/misc/fs-helper";
Expand Down Expand Up @@ -65,6 +66,7 @@ export default class RunManifestTestsCommand extends RunTestsDownloadResultComma
throw new Error("XML merging has ended with an error");
}

await writeFile(path.join(outputDir, this.outputXmlName), xml);
const strXml: string = new XMLSerializer().serializeToString(xml);
await writeFile(path.join(outputDir, this.outputXmlName), strXml);
}
}