[CodePush] Add support for Xcode11 #751
Conversation
jp-andre
left a comment
jp-andre
left a comment
There was a problem hiding this comment.
Is there any chance we could have some test cases with this? Testing that parsing works correctly on some sample file, etc...
| @shortName("c") | ||
| @hasArg | ||
| @longName("build-configuration-name") | ||
| public buildConfigurationName: string; |
There was a problem hiding this comment.
Is this a mandatory argument?
There was a problem hiding this comment.
Oh I just saw in another line that it defaults to Release. Why not here?
There was a problem hiding this comment.
Yes, you're right. I already fixed it. Thanks!
| } | ||
| out.text(`Using the target binary version value "${marketingVersion}" from "${resolvedPbxprojFile}".\n`); | ||
|
|
||
| return Promise.resolve(marketingVersion); |
There was a problem hiding this comment.
I think we can skip the Promise.resolve() here since the method is async already.
|
@jp-andre We'll schedule a feature to add missing tests for all of the release commands in the next weeks. Right now, there are no tests for most of the Does that make sense to you? |
Yes, considering the situation this is perfectly understandable. I'll work on a release. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
4 participants
Issue: Starting with Xcode 11 when changing the version of the application, it is saved into the
project.pbxprojinstead ofInfo.plist. And link to$MARKETING_VERSIONis put ininfo.plist. This does not allow appcenter-cli to make the release a new version, because it cannot get the current version fromInfo.plist. Moreover, customers can change the version for each build configuration (Release or Debug and etc.) individually.Solution: We implemented logic that allows getting the
$MARKETING_VERSIONfrom theproject.pbxprojfile. Appcenter-cli will take the default version ofReleasebuild configuration, But if the customer wants to create a release for another Build configuration, he can add an option flag with the Build configuration name to the react-release command.