Fix react-native build with hermes enabled on Windows#811
Merged
anywherepilot merged 2 commits intomicrosoft:masterfrom Apr 21, 2020
Merged
Fix react-native build with hermes enabled on Windows#811anywherepilot merged 2 commits intomicrosoft:masterfrom
anywherepilot merged 2 commits intomicrosoft:masterfrom
Conversation
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
anywherepilot
approved these changes
Apr 21, 2020
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fixes #693.
For now, we can't deploy a react-native release on Windows with hermes enabled because the script looks for an executable file without a
.exefile extension, whereas on Windows, we need a.exeextension, throwing an ENOENT error.Full error:
This PR add a function to look for platform specific executable file extension.