Skip to content

Set setCustomProperties API to protected#415

Merged
guperrot merged 2 commits intomicrosoft:pushfrom
akvelon:fix/hide-custom-properties-api
Apr 27, 2017
Merged

Set setCustomProperties API to protected#415
guperrot merged 2 commits intomicrosoft:pushfrom
akvelon:fix/hide-custom-properties-api

Conversation

@MatkovIvan
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Apr 27, 2017

Codecov Report

Merging #415 into push will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##           push   #415   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files        92     92           
  Lines      3944   3944           
  Branches    546    546           
===================================
  Hits       3944   3944
Impacted Files Coverage Δ
.../java/com/microsoft/azure/mobile/MobileCenter.java 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abac23d...9bfbaf0. Read the comment docs.

Copy link
Member

@guperrot guperrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sasquatch is broken for custom properties but we should keep it working there, should use setAccessible(true) trick there and please log an error instead of ignore throwable, it was confusing during debug ;)

@guperrot guperrot merged commit 103252b into microsoft:push Apr 27, 2017
@MatkovIvan MatkovIvan deleted the fix/hide-custom-properties-api branch May 12, 2017 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants