Revert "Add an AppHost and PreviewHost for serving site previews"#642
Merged
IEvangelist merged 1 commit intomainfrom Mar 30, 2026
Merged
Revert "Add an AppHost and PreviewHost for serving site previews"#642IEvangelist merged 1 commit intomainfrom
IEvangelist merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts the accidentally merged PR #641 by removing the PreviewHost/Preview AppHost implementation and associated PR-preview GitHub workflows, restoring the repo state to match pre-merge main behavior.
Changes:
- Removes the
PreviewHostservice (API + static UI shell assets) and theAspire.Dev.Preview.AppHostproject. - Deletes PR preview registration/cleanup workflows and restores fixed frontend artifact publishing behavior.
- Removes Astro
basepath handling that was introduced for per-PR preview routing.
Reviewed changes
Copilot reviewed 31 out of 35 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/statichost/PreviewHost/wwwroot/_preview/status.js | Deleted PR preview status page client script. |
| src/statichost/PreviewHost/wwwroot/_preview/status.html | Deleted PR preview status page shell HTML. |
| src/statichost/PreviewHost/wwwroot/_preview/retry-arrow.svg | Deleted preview UI asset. |
| src/statichost/PreviewHost/wwwroot/_preview/preview.css | Deleted preview UI stylesheet. |
| src/statichost/PreviewHost/wwwroot/_preview/left-arrow.svg | Deleted preview UI asset. |
| src/statichost/PreviewHost/wwwroot/_preview/index.js | Deleted PR preview catalog page client script. |
| src/statichost/PreviewHost/wwwroot/_preview/index.html | Deleted PR preview catalog page shell HTML. |
| src/statichost/PreviewHost/wwwroot/_preview/github-mark.svg | Deleted preview UI asset. |
| src/statichost/PreviewHost/wwwroot/_preview/aspire-mark.svg | Deleted preview UI asset. |
| src/statichost/PreviewHost/Properties/launchSettings.json | Deleted PreviewHost launch settings. |
| src/statichost/PreviewHost/Program.cs | Deleted PreviewHost ASP.NET app entrypoint and endpoints. |
| src/statichost/PreviewHost/Previews/PreviewStateStore.cs | Deleted PreviewHost state storage implementation. |
| src/statichost/PreviewHost/Previews/PreviewRequestDispatcher.cs | Deleted PreviewHost request routing/rewriting logic. |
| src/statichost/PreviewHost/Previews/PreviewModels.cs | Deleted PreviewHost models/options types. |
| src/statichost/PreviewHost/Previews/PreviewCoordinator.cs | Deleted PreviewHost artifact load/orchestration logic. |
| src/statichost/PreviewHost/Previews/PreviewBufferSettings.cs | Deleted PreviewHost adaptive buffer sizing helper. |
| src/statichost/PreviewHost/Previews/GitHubArtifactClient.cs | Deleted PreviewHost GitHub artifact/PR query client. |
| src/statichost/PreviewHost/Previews/CommandLineExtractionSupport.cs | Deleted PreviewHost command-line extraction support helper. |
| src/statichost/PreviewHost/PreviewHost.csproj | Deleted PreviewHost project file and dependencies. |
| src/statichost/PreviewHost/Dockerfile | Deleted PreviewHost container build definition. |
| src/statichost/PreviewHost/appsettings.json | Deleted PreviewHost default config. |
| src/statichost/PreviewHost/appsettings.Development.json | Deleted PreviewHost dev config. |
| src/statichost/PreviewHost/.dockerignore | Deleted PreviewHost dockerignore. |
| src/frontend/astro.config.mjs | Removes configurable base path support added for PR preview hosting. |
| src/apphost/Aspire.Dev.Preview.AppHost/Properties/launchSettings.json | Deleted Preview AppHost launch settings. |
| src/apphost/Aspire.Dev.Preview.AppHost/Aspire.Dev.Preview.AppHost.csproj | Deleted Preview AppHost project. |
| src/apphost/Aspire.Dev.Preview.AppHost/appsettings.json | Deleted Preview AppHost config. |
| src/apphost/Aspire.Dev.Preview.AppHost/appsettings.Development.json | Deleted Preview AppHost dev config. |
| src/apphost/Aspire.Dev.Preview.AppHost/AppHost.cs | Deleted Preview AppHost orchestration code. |
| Aspire.Dev.slnx | Removes PreviewHost and Preview AppHost from the solution. |
| .github/workflows/pr-preview-register.yml | Deleted workflow that registered preview artifacts / updated PR descriptions. |
| .github/workflows/pr-preview-cleanup.yml | Deleted workflow that cleaned up preview registrations / PR description block. |
| .github/workflows/frontend-build.yml | Reverts to fixed artifact name/retention; removes PR-preview-specific inputs/env. |
| .github/workflows/ci.yml | Stops passing PR-preview-specific inputs into frontend-build.yml. |
| .github/workflows/apphost-build.yml | Reverts to building only the main AppHost (removes matrix for Preview AppHost). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
davidfowl
approved these changes
Mar 30, 2026
IEvangelist
added a commit
that referenced
this pull request
Mar 31, 2026
This reapplies the per-PR preview implementation that was reverted by PR #642, restoring the PreviewHost, preview AppHost, workflow automation, UI, and performance hardening work onto the redraft branch. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
IEvangelist
added a commit
that referenced
this pull request
Mar 31, 2026
This reapplies the per-PR preview implementation that was reverted by PR #642, restoring the PreviewHost, preview AppHost, workflow automation, UI, and performance hardening work onto the redraft branch. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This reverts the changes introduced by accidentally merged PR #641.
Validation
mainat06424095eb476f4cd29c1fe47ba1c648853708a7mainon branchdapine/revert-pr-641