Address lingering feedback from #672

[IEvangelist]

Summary

• restore localized 404 detection in FooterLinks by using the Starlight route slug with a pathname fallback
• relax OsAwareTabs tab activation to work with any tab element that exposes text content, not just anchors
• refine frontend ESLint test overrides so only e2e tests disable typed linting, while Astro unit and prop-contract suites keep type-aware linting with narrow unsafe-rule exemptions
• add focused unit coverage for localized 404 footer behavior and the OsAwareTabs inline activation script

Validation

• pnpm --dir src/frontend test:unit:components
• pnpm --dir src/frontend exec playwright test tests/e2e/custom-components.spec.ts --project=desktop-chromium
• pnpm --dir src/frontend exec eslint tests/typecheck/component-props.contracts.ts tests/unit/custom-components.vitest.test.ts tests/e2e/custom-components.spec.ts
• pnpm --dir src/frontend lint

Refs: #672

[Copilot]

Pull request overview

This PR addresses follow-up feedback from #672 by restoring correct localized 404 handling in the footer, loosening OsAwareTabs tab activation assumptions, and adding targeted unit coverage to prevent regressions in these areas.

Changes:

• Restore localized 404 detection in FooterLinks using starlightRoute.entry.slug with a pathname-regex fallback.
• Update OsAwareTabs activation logic to match tabs by textContent without requiring anchor elements.
• Add unit tests covering localized 404 footer behavior and the updated OsAwareTabs inline activation logic.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/frontend/tests/unit/custom-components.vitest.test.ts	Adds render-based unit tests for localized 404 footer behavior and OsAwareTabs script assumptions.
src/frontend/src/components/OsAwareTabs.astro	Relaxes tab detection to work with any tab element exposing text content (not just anchors).
src/frontend/src/components/FooterLinks.astro	Improves 404 detection for localized routes using Starlight route metadata with a pathname fallback.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.