Skip to content

Document AppHost path config guardrails#862

Merged
maddymontaquila merged 7 commits into
mainfrom
adamint/docs-apphost-path-guardrails
May 6, 2026
Merged

Document AppHost path config guardrails#862
maddymontaquila merged 7 commits into
mainfrom
adamint/docs-apphost-path-guardrails

Conversation

@adamint
Copy link
Copy Markdown
Member

@adamint adamint commented May 6, 2026

Summary

  • Documents appHost.path as the supported local AppHost path setting.
  • Clarifies that AppHost paths cannot be configured globally and are ignored with a warning if present in global settings.
  • Notes that the legacy appHostPath key is blocked by aspire config set.

Addresses item 8 in #837.

Validation

  • Reviewed rendered docs with doc-tester/Playwright.
  • Tested the documented CLI behavior with Aspire CLI 13.3.0.
  • pnpm --dir ./src/frontend run lint
  • pnpm --dir ./src/frontend run test:unit:docs

Clarify that appHost.path is a local project-scoped setting, global AppHost paths are ignored, and legacy appHostPath cannot be set with aspire config set.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 6, 2026 20:18
Comment thread src/frontend/src/content/docs/reference/cli/configuration.mdx Outdated
Comment thread src/frontend/src/content/docs/reference/cli/configuration.mdx Outdated
Comment thread src/frontend/src/content/docs/reference/cli/configuration.mdx Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Aspire CLI configuration documentation to describe appHost.path as the supported local AppHost path setting, clarifies that AppHost paths are not configurable via global settings (and are ignored with a warning if present), and notes that the legacy appHostPath key is blocked by aspire config set.

Changes:

  • Updates the config settings table to document appHost.path (instead of legacy appHostPath).
  • Adds a dedicated “Configure the AppHost path” section explaining local-only behavior and legacy key handling.
  • Adds guardrail notes to the config file description include and the aspire config set command reference.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/frontend/src/content/docs/reference/cli/includes/config-settings-table.md Updates documented config keys to appHost.path and adjusts descriptions accordingly.
src/frontend/src/content/docs/reference/cli/includes/config-file-description.md Adds a note that appHost.path must be configured locally.
src/frontend/src/content/docs/reference/cli/configuration.mdx Adds an AppHost path configuration section and updates examples/references to appHost.path.
src/frontend/src/content/docs/reference/cli/commands/aspire-config-set.mdx Clarifies that project-specific settings like appHost.path aren’t global-settable.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/frontend/src/content/docs/reference/cli/includes/config-settings-table.md Outdated
Comment thread src/frontend/src/content/docs/reference/cli/configuration.mdx Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment thread src/frontend/src/content/docs/reference/cli/configuration.mdx Outdated
adamint and others added 2 commits May 6, 2026 16:24
Use AppHost entry point terminology and a script entry point example so the docs do not imply appHost.path must reference a project file.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@maddymontaquila maddymontaquila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

luv it

@maddymontaquila maddymontaquila merged commit 8c7053a into main May 6, 2026
5 checks passed
@maddymontaquila maddymontaquila deleted the adamint/docs-apphost-path-guardrails branch May 6, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants